chore: Replace deprecated jpeg-exif with jay-peg for JPEG parsing#1678
Closed
exoego wants to merge 1 commit intofoliojs:masterfrom
Closed
chore: Replace deprecated jpeg-exif with jay-peg for JPEG parsing#1678exoego wants to merge 1 commit intofoliojs:masterfrom
exoego wants to merge 1 commit intofoliojs:masterfrom
Conversation
exoego
force-pushed
the
replace-jpeg-exif
branch
from
150e288 to
5b97a5b
Compare
Member
|
Since we only need exif the orientation, we could write a simpler jpeg parser just to extract the orientation, instead of relying of a library. This is on my backlog for sometime The tests already in place should be enough Should be able to fix #1175 also which jay-peg currently does not handle Here's one implementation https://getaround.tech/exif-data-manipulation-javascript/ Can you do a PR using this approach? |
Contributor
Author
|
@blikblum BTW, #1175 will be fixed in jay-peg in diegomura/jay-peg#24 |
Contributor
Author
|
Superseded by #1680 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Replaces jpeg-exifwith jay-peg.
Note that the author of jay-peg is the author of react-pdf too. (not me)
Checklist: