feat(): upgrade to pg18 and upgrade to latest others#296
feat(): upgrade to pg18 and upgrade to latest others#296semoal wants to merge 17 commits intofly-apps:masterfrom
Conversation
|
I think, we should also upgrade HAProxy version to 3.2.0 it brings tons of performance improvements |
|
According to the linked issue pg 18 is supported now |
I would update the pr tomorrow and also will upgrade HA Proxy |
|
Updated all others minors to latest, upgraded pg to 18.1, and also HAProxy to 3.3! I think this pr is ready to be reviewed :) |
|
Hey there, thanks for the PR! The changes look good overall. For now though, I’d like to scope the HAProxy 2.8 → 3.3 bump to the Happy to revisit bumping HAProxy for older PG versions once we’ve built some confidence. |
That makes a lot of sense, let me revert it back and we can ship this for now. |
semoal
force-pushed
the
semoal/upgrade-deps-pg18
branch
from
9f756d5 to
c38a1b2
Compare
semoal
force-pushed
the
semoal/upgrade-deps-pg18
branch
from
c38a1b2 to
1272287
Compare
|
By the way, had the possibility to test the Dockerfile and run a new machine and dump our development database and everything is running smoothly: |
There was a problem hiding this comment.
Pull request overview
This PR upgrades PostgreSQL versions across multiple major releases and introduces support for PostgreSQL 18. The changes update existing Dockerfiles with newer patch versions and add new Docker image configurations for PostgreSQL 18.
- Updates PostgreSQL 15 from 15.10 to 15.15
- Updates PostgreSQL 16 from 16.6 to 16.11
- Updates PostgreSQL 17 from 17.2 to 17.7
- Adds support for PostgreSQL 18.1 with both standard and TimescaleDB variants
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pg15/Dockerfile | Updates PG_VERSION to 15.15 |
| pg15/Dockerfile-timescaledb | Updates PG_VERSION to 15.15 for TimescaleDB variant |
| pg16/Dockerfile | Updates PG_VERSION to 16.11 |
| pg16/Dockerfile-timescaledb | Updates PG_VERSION to 16.11 for TimescaleDB variant |
| pg17/Dockerfile | Updates PG_VERSION to 17.7 |
| pg17/Dockerfile-timescaledb | Updates PG_VERSION to 17.7 for TimescaleDB variant |
| pg18/Dockerfile | Adds new Dockerfile for PostgreSQL 18.1 with HAProxy 3.3 |
| pg18/Dockerfile-timescaledb | Adds new Dockerfile for PostgreSQL 18.1 with TimescaleDB support |
| .github/workflows/ci.yaml | Updates CI workflow to build and push all updated versions including new pg18 images |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Anything holding this up? Happy to help if needed. |
|
Is it possible to use this before fly lands it? @dangra are you able to land this? |
I'm running this branch already smoothly for 3 months on our development environment without problems 👍 |
|
Kind of getting the message mpg is the future of this on fly. Just had a series of breakdowns around unmanaged pg. no data loss but a bunch of downtime, and ran into a bunch of cli stacktraces during basic operations. Of the tools I assumed I had access too, they aren't working well when you need them. Unfortunate there isn't a cheaper tier for small projects but I guess in order to offer base level ha you it comes in around $40/mo. I think if I went unmanaged again, I would just deploy raw images to machines rather than rely on the opaque fly tooling, that seems to be slowly degrading. They should really offramp people from this EOL product. |
Removed unnecessary blank lines and ensured proper formatting in the CI workflow.
|
@semoal I tried to get this in shape to merge as it was looking so good. the problem is that at least Timescale 15.15 isn't building. I would suggest sticking to add pg 18 in this PR and we can shake the others in another change. I ran out of time budget at the moment to continue on this but if you fix the issues and the CI passes, I will merge asap. |
apt-key was removed in Debian 12+/Ubuntu 22.04+. Updated all TimescaleDB Dockerfiles to use modern signed-by keyring approach instead. Fixes build error: /bin/sh: 1: apt-key: not found
- pg15: 15.15 → 15.17 - pg16: 16.11 → 16.13 - pg17: 17.7 → 17.9 - pg18: 18.1 → 18.3 Latest release: February 26, 2026
Just pushed the fixes, if you can approve the run we double-check! 👍 |
Haproxy was installed twice - once from default repos and again from haproxy.debian.net. This caused a downgrade error. Now only installed from the specific versioned repo.
Project go.mod requires Go 1.26 but Dockerfile was using golang:1.23. This caused build failure: 'go.mod requires go >= 1.26'
PostgreSQL Version Updates
Updated all PostgreSQL versions to latest minor releases (February 26, 2026):
Bug Fixes
apt-keyusage in all TimescaleDB Dockerfiles (pg15, pg16, pg17, pg18)gpg --dearmor+signed-by=keyring approachapt-keywas removed