[go_router] Fix assertion failure on URLs with hash fragments missing leading slash#11431
Open
chunhtai wants to merge 2 commits intoflutter:mainfrom
Open
[go_router] Fix assertion failure on URLs with hash fragments missing leading slash#11431chunhtai wants to merge 2 commits intoflutter:mainfrom
chunhtai wants to merge 2 commits intoflutter:mainfrom
Conversation
github-actions
bot
added
p: go_router
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies RouteConfiguration.normalizeUri to ensure paths consistently start with a leading slash and removes trailing slashes for paths longer than one character. It includes new unit and widget tests to verify these changes and ensure that query parameters and fragments are preserved. A review comment suggests optimizing the normalization process by returning the original URI when no path changes are required to avoid unnecessary object allocation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#184109
Fixes flutter/flutter#181629