fix: Set default status to 'pending' for verification codes#191
Merged
roncodes merged 1 commit intodev-v1.6.36from Feb 24, 2026
Merged
fix: Set default status to 'pending' for verification codes#191roncodes merged 1 commit intodev-v1.6.36from
roncodes merged 1 commit intodev-v1.6.36from
Conversation
The VerificationCode model was creating records with NULL status because
the generateFor() method never initialized the status field.
This caused issues when querying for verification codes with:
->where('status', 'pending')
Now all verification codes are created with status = 'pending' by default,
which is the expected behavior for newly generated codes.
Fixes verification flow for email and SMS verification codes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
VerificationCodemodel was creating records withNULLstatus because thegenerateFor()method never initialized the status field.This caused issues when querying for verification codes with:
All queries would fail to find the verification code, resulting in "Invalid or expired verification code" errors even with valid codes.
Solution
Set
status = 'pending'by default in thegenerateFor()method, which is called by bothgenerateEmailVerificationFor()andgenerateSmsVerificationFor().Changes
$verifyCode->status = 'pending';ingenerateFor()methodImpact
Fixes verification flow for:
Testing
After this fix, verification codes will be created with
status = 'pending'and can be properly queried and validated.