Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Fishjam React Native example app configuration so it no longer uses Fishjam-owned application identifiers by default, and documents what identifiers users must customize before building on their own devices.
Changes:
- Replaced Fishjam-specific iOS bundle identifiers and Android package name with
com.example.*placeholders inapp.json. - Updated the iOS ScreenBroadcastExtension bundle identifier and app group entitlement to match the new placeholder namespace.
- Added a README note instructing users which
app.jsonfields must be updated before runningexpo prebuild.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| examples/mobile-client/fishjam-chat/app.json | Switches iOS/Android identifiers and iOS extension/app-group IDs to non-Fishjam placeholders. |
| examples/mobile-client/fishjam-chat/README.md | Adds build guidance to update identifiers prior to prebuilding native projects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made changes to describe how to build the example app
Motivation and Context
bundleIdentifier on iOS was tied to fishjam and wouldn't build on real device for people outside of fishjam org
Documentation impact
Types of changes
not work as expected)