Add "Add to Kiro" MCP badge to README#10307
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request updates the README.md to include a Kiro badge for the Firebase MCP server. The review suggests standardizing the Kiro configuration to use 'firebase-tools@latest' and removing the '--dir .' argument to ensure consistency with other MCP client configurations.
| @@ -1,4 +1,4 @@ | |||
| # Firebase CLI and MCP Server [![Actions Status][gh-actions-badge]][gh-actions] [![Node Version][node-badge]][npm] [![NPM version][npm-badge]][npm] [](https://cursor.com/en/install-mcp?name=firebase&config=eyJjb21tYW5kIjoibnB4IiwiYXJncyI6WyIteSIsImZpcmViYXNlLXRvb2xzIiwibWNwIiwiLS1kaXIiLCIuIl19) | |||
| # Firebase CLI and MCP Server [![Actions Status][gh-actions-badge]][gh-actions] [![Node Version][node-badge]][npm] [![NPM version][npm-badge]][npm] [](https://cursor.com/en/install-mcp?name=firebase&config=eyJjb21tYW5kIjoibnB4IiwiYXJncyI6WyIteSIsImZpcmViYXNlLXRvb2xzIiwibWNwIiwiLS1kaXIiLCIuIl19) [](https://kiro.dev/launch/mcp/add?name=firebase&config=%7B%22command%22%3A%22npx%22%2C%22args%22%3A%5B%22-y%22%2C%22firebase-tools%22%2C%22mcp%22%2C%22--dir%22%2C%22.%22%5D%7D) | |||
There was a problem hiding this comment.
The configuration for the Kiro badge seems inconsistent with the recommended setup for other MCP clients. As seen in src/mcp/README.md, the standard configuration for tools like Cursor and Claude Code uses firebase-tools@latest and omits the --dir . argument.
Using firebase-tools@latest ensures users always get the most recent version, and omitting --dir . avoids potential issues with a non-standard flag, relying on the tool's default behavior for setting the working directory.
To improve consistency and robustness, I suggest updating the Kiro badge's configuration to follow this standard pattern.
| # Firebase CLI and MCP Server [![Actions Status][gh-actions-badge]][gh-actions] [![Node Version][node-badge]][npm] [![NPM version][npm-badge]][npm] [](https://cursor.com/en/install-mcp?name=firebase&config=eyJjb21tYW5kIjoibnB4IiwiYXJncyI6WyIteSIsImZpcmViYXNlLXRvb2xzIiwibWNwIiwiLS1kaXIiLCIuIl19) [](https://kiro.dev/launch/mcp/add?name=firebase&config=%7B%22command%22%3A%22npx%22%2C%22args%22%3A%5B%22-y%22%2C%22firebase-tools%22%2C%22mcp%22%2C%22--dir%22%2C%22.%22%5D%7D) | |
| # Firebase CLI and MCP Server [![Actions Status][gh-actions-badge]][gh-actions] [![Node Version][node-badge]][npm] [![NPM version][npm-badge]][npm] [](https://cursor.com/en/install-mcp?name=firebase&config=eyJjb21tYW5kIjoibnB4IiwiYXJncyI6WyIteSIsImZpcmViYXNlLXRvb2xzIiwibWNwIiwiLS1kaXIiLCIuIl19) [](https://kiro.dev/launch/mcp/add?name=firebase&config=%7B%22command%22%3A%22npx%22%2C%22args%22%3A%5B%22-y%22%2C%22firebase-tools%40latest%22%2C%22mcp%22%5D%7D) |
Description
zAdding on click install for Kiro IDE to README
Scenarios Tested
Sample Commands