Open
Conversation
Member
inlined
commented
Apr 9, 2026
- Updates don't have to have every field (whatever happened to this being the default and using field_mask?)
- A function trigger not being registered doesn't make the function undeletable
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AILogic service to handle 404 errors during trigger deletion by logging a warning instead of throwing an exception, and modifies the default value of allowMissing to true in updateTrigger. I recommend simplifying the error handling logic in ailogic.ts by utilizing the getErrStatus utility from src/error.ts to improve readability and maintain consistency with repository standards. Additionally, please verify if changing the default allowMissing parameter in updateTrigger could introduce unintended side effects for other callers.
joehan
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.