Skip to content

Harden FAL registration#10306

Open
inlined wants to merge 4 commits intomainfrom
inlined.fal-fixes
Open

Harden FAL registration#10306
inlined wants to merge 4 commits intomainfrom
inlined.fal-fixes

Conversation

@inlined
Copy link
Copy Markdown
Member

@inlined inlined commented Apr 9, 2026

  1. Updates don't have to have every field (whatever happened to this being the default and using field_mask?)
  2. A function trigger not being registered doesn't make the function undeletable

@inlined inlined requested a review from joehan April 9, 2026 19:31
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AILogic service to handle 404 errors during trigger deletion by logging a warning instead of throwing an exception, and modifies the default value of allowMissing to true in updateTrigger. I recommend simplifying the error handling logic in ailogic.ts by utilizing the getErrStatus utility from src/error.ts to improve readability and maintain consistency with repository standards. Additionally, please verify if changing the default allowMissing parameter in updateTrigger could introduce unintended side effects for other callers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants