Standardize configuration in example scripts#715
Conversation
Refactors the example scripts in `examples/basic/` and `examples/async/` to use `imednet.load_config()` instead of hardcoded placeholder credentials. This encourages secure practices by loading credentials from environment variables (e.g., via a `.env` file). - Added `examples/README.md` with setup instructions. - Updated all basic examples to use `load_config` and `configure_json_logging`. - Updated async example to use `load_config` and `configure_json_logging`. - Fixed linting errors in modified files. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
fderuiter
deleted the
doc/standardize-examples-configuration-13367053745185861414
branch
1 participant
Standardized configuration loading in
examples/scripts.Changes
examples/README.mdto document how to run examples and set up the environment.examples/basic/*.pyandexamples/async/get_records_async.pyto:load_configandconfigure_json_loggingfromimednet.cfg = load_config()instead of hardcoded strings.main()functions withif __name__ == "__main__":blocks.Verification
examples/basic/get_studies.py(after setting PYTHONPATH) to verify it fails gracefully without credentials (confirmingload_configlogic).ruff check examples/and fixed linting issues.tests/unit/test_config.py) pass.PR created automatically by Jules for task 13367053745185861414 started by @fderuiter