fix: handle parser re-entry from chaining plugins#262
Merged
Conversation
Some Prettier plugins, such as `prettier-plugin-tailwindcss`, compose parsers by resolving the active parser chain again during preprocess or parse. When that chain points back at this plugin, the old module-level recursion guard could either recurse indefinitely or make unrelated concurrent format calls skip JSDoc processing. Track active preprocess and parse calls per Prettier options object instead. Recursive entries for the same format call fall back to the raw Prettier parser, while separate format calls continue to run through the JSDoc parser normally. Add a fake chaining plugin fixture to cover both plugin orders and concurrent format calls. Closes: fardad-dev#254
Collaborator
Contributor
Author
|
Thanks! Hmm, I don't think it was necessary to merge that one. Buuuut if the new tests from this PR pass then I think it shouldn't cause any problems. |
Collaborator
|
Thanks for the confirmation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Prettier plugins, such as
prettier-plugin-tailwindcss, compose parsers by resolving the active parser chain again during preprocess or parse. When that chain points back at this plugin, the old module-level recursion guard could either recurse indefinitely or make unrelated concurrent format calls skip JSDoc processing.Track active preprocess and parse calls per Prettier options object instead. Recursive entries for the same format call fall back to the raw Prettier parser, while separate format calls continue to run through the JSDoc parser normally.
Add a fake chaining plugin fixture to cover both plugin orders and concurrent format calls.
Closes: #254