fix(again): Allow account deactivation even with disabled profile changes#249
Merged
jason-famedly merged 3 commits intofamedly-release/v1.150from Mar 30, 2026
Merged
Conversation
jason-famedly
force-pushed
the
jason/fixup-profile-deletion
branch
from
16a46b0 to
a720db9
Compare
jason-famedly
force-pushed
the
famedly-release/v1.150
branch
from
d84a2a5 to
e2d4fbc
Compare
jason-famedly
force-pushed
the
jason/fixup-profile-deletion
branch
from
a720db9 to
26006a1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## famedly-release/v1.150 #249 +/- ##
=========================================================
Coverage ? 80.18%
=========================================================
Files ? 501
Lines ? 71674
Branches ? 10774
=========================================================
Hits ? 57471
Misses ? 10939
Partials ? 3264
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
The 'deactivation' argument was removed from the profile handler setting methods. Will have to use another method Keeping the tests
jason-famedly
force-pushed
the
jason/fixup-profile-deletion
branch
from
26006a1 to
5628aa8
Compare
Member
|
while we're at it, we could add docstrings to the tests? |
And refactor a test helper that was mostly duplicated code
jason-famedly
force-pushed
the
jason/fixup-profile-deletion
branch
from
5628aa8 to
6b7201d
Compare
Member
Author
I forced pushed that change, should be visible from the 'compare' button. I rearranged the tests slightly too and added additional verification that seemed to be missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by upstream changes. Same behavior as before, just adjust to be in a new function instead
Fixes: #248
Replaces #84