Skip to content

[FC-384] Add sysadmin to oauth flow and change the admin_path#82

Open
mzaniolo wants to merge 2 commits intomainfrom
mzaniolo/sysadmin
Open

[FC-384] Add sysadmin to oauth flow and change the admin_path#82
mzaniolo wants to merge 2 commits intomainfrom
mzaniolo/sysadmin

Conversation

@mzaniolo
Copy link
Copy Markdown
Contributor

@mzaniolo mzaniolo commented Apr 1, 2026

Closes: FC-384

@mzaniolo mzaniolo requested a review from a team as a code owner April 1, 2026 14:31
@mzaniolo mzaniolo force-pushed the mzaniolo/sysadmin branch 2 times, most recently from db33530 to b11fab7 Compare April 1, 2026 14:41
@mzaniolo mzaniolo force-pushed the mzaniolo/sysadmin branch from b11fab7 to cd0d671 Compare April 1, 2026 14:45
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 93.18182% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.69%. Comparing base (8ad0e2a) to head (cd0d671).

Files with missing lines Patch % Lines
tests/server.py 70.00% 2 Missing and 1 partial ⚠️
tests/synapse_clock.py 60.00% 2 Missing ⚠️
tests/unittest.py 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   83.08%   83.69%   +0.60%     
==========================================
  Files          18       19       +1     
  Lines        1874     1950      +76     
  Branches      193      198       +5     
==========================================
+ Hits         1557     1632      +75     
- Misses        234      235       +1     
  Partials       83       83              
Files with missing lines Coverage Δ
synapse_token_authenticator/config.py 70.40% <100.00%> (+1.59%) ⬆️
synapse_token_authenticator/token_authenticator.py 72.72% <100.00%> (+1.26%) ⬆️
tests/__init__.py 89.56% <100.00%> (ø)
tests/test_oauth.py 100.00% <100.00%> (ø)
tests/unittest.py 86.14% <83.33%> (-0.28%) ⬇️
tests/synapse_clock.py 60.00% <60.00%> (ø)
tests/server.py 77.77% <70.00%> (-0.89%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad0e2a...cd0d671. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant