upgrading tokio to 1.52.1#1288
Open
zbowling wants to merge 1 commit intofacebook:mainfrom
Open
Conversation
Summary: X-link: facebookincubator/below#8278 X-link: https://github.com/facebookexperimental/dapper/pull/1 X-link: meta-pytorch/monarch#3495 Upgrading `tokio` from `1.50.0` to `1.52.1`. - All downstream consumers checked with arc rust-check — 0 errors. Reviewed By: dtolnay Differential Revision: D101580193
|
@zbowling has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101580193. |
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Rust async runtime dependency tokio from 1.50.0 to 1.52.1 across a broad set of Eden/SCM, Mononoke, and shared rust-shed crates to keep the dependency set consistent for downstream consumers.
Changes:
- Bump
tokiodependency versions from1.50.0to1.52.1across many crate manifests. - Update both normal and dev-dependency
tokioentries where present (including optional deps).
Reviewed changes
Copilot reviewed 140 out of 140 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| eden/scm/lib/workingcopy/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/vfs/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/streams/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/scm/lib/sparse/Cargo.toml | Bump tokio (optional + dev-dependency) to 1.52.1 |
| eden/scm/lib/revisionstore/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/progress/model/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/pathhistory/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/minibench/examples/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/http-client/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/edenapi/ext/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/edenapi/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/eagerepo/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/scm/lib/dag/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/cpython-async/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/scm/lib/copytrace/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/scm/lib/commitcloudsubscriber/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/lib/async-runtime/Cargo.toml | Bump tokio to 1.52.1 |
| eden/scm/exec/scm_daemon/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/testtool/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/tail-to-cloudwatch/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/streaming_clone/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/repo_import/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/packer/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/executor/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/bonsai_verify/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/aliasverify/tools/aliasverify/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/tools/admin/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/servers/slapi/slapi_service/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/servers/slapi/slapi_server/repo_listener/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/servers/slapi/slapi_server/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/servers/scs/scs_methods/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/servers/lfs/lfs_server/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/servers/git/git_server/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_factory/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_client/wirepack/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/mononoke/repo_client/unbundle/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/mononoke/repo_attributes/restricted_paths_common/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/restricted_paths/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/repo_permission_checker/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/repo_event_publisher/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/repo_derivation_queues/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/newfilenodes/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/git_ref_content_mapping/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/filestore/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/commit_graph/preloaded_commit_graph_storage/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/commit_graph/commit_graph/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/bookmarks/warm_bookmarks_cache/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/bookmarks/dbbookmarks/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/bookmarks/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/bonsai_tag_mapping/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/repo_attributes/bonsai_globalrev_mapping/globalrev_pushrebase_hook/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/mononoke_types/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/mononoke_api_hg/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/mononoke_api/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/mercurial/types/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/mercurial/bundles/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/manifest/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/lfs_import_lib/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/jobs/walker/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/jobs/statistics_collector/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/jobs/modern_sync/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/jobs/cas_sync/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/jobs/blobstore_healer/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/git/protocol/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/git/packfile/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/git/packetline/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/git/import_tools/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/git/gitexport/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/git/git_types/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/git/git-pool/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/git/check_git_wc/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/repo_stats_logger/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/pushrebase/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/microwave/features/microwave/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/hooks/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/history_traversal/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/diff/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/cross_repo_sync/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/commit_rewriting/mononoke_x_repo_sync_job/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/commit_rewriting/commit_validator/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/commit_rewriting/bookmarks_validator/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/commit_rewriting/backsyncer/features/commit_rewriting/backsyncer_cmd/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/commit_rewriting/backsyncer/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/async_requests/worker_lib/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/async_requests/worker/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/async_requests/requests_table/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/features/async_requests/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/derived_data/mercurial_derivation/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/derived_data/manager/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/derived_data/inferred_copy_from/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/derived_data/deleted_manifest/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/yield_stream/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/mononoke/common/wait_for_replication/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/rust/sql_ext/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/rust/caching_ext/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/mononoke/common/running/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/rendezvous/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/reloader/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/rate_limiting/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/quiet_stream/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/permission_checker/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/ods_counters/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/mononoke_macros/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/mononoke_configs/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/metadata/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/hgproto/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/gotham_ext/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/cas_client/client/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/async_limiter/examples/tokio_v2/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/common/async_limiter/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/mononoke/common/assembly_line/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| eden/mononoke/cmdlib/sharding/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/cmdlib/mononoke_app/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/cmdlib/environment/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/cmdlib/config_args/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/virtually_sharded_blobstore/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/test_utils/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/sqlblob/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/s3blob/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/multiplexedblob_wal/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/multiplexedblob/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/fileblob/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/factory/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/ephemeral_blobstore/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/delayblob/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobstore/cacheblob/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobrepo_utils/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/blobimport_lib/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/benchmarks/storage_config/Cargo.toml | Bump tokio to 1.52.1 |
| eden/mononoke/benchmarks/filestore/Cargo.toml | Bump tokio to 1.52.1 |
| eden/fs/rust/redirect_ffi/Cargo.toml | Bump tokio to 1.52.1 |
| eden/fs/rust/edenfs-asserted-states/Cargo.toml | Bump tokio to 1.52.1 |
| eden/fs/cli_rs/sapling-client/Cargo.toml | Bump tokio to 1.52.1 |
| eden/fs/cli_rs/edenfs-error/Cargo.toml | Bump tokio to 1.52.1 |
| eden/fs/cli_rs/edenfs-client/Cargo.toml | Bump tokio (dev-dependency) to 1.52.1 |
| common/rust/shed/tokio-uds-compat/Cargo.toml | Bump tokio to 1.52.1 |
| common/rust/shed/stats/Cargo.toml | Bump tokio to 1.52.1 |
| common/rust/shed/futures_stats/Cargo.toml | Bump tokio to 1.52.1 |
| common/rust/shed/futures_ext/Cargo.toml | Bump tokio to 1.52.1 |
| common/rust/shed/fbinit/fbinit-tokio/Cargo.toml | Bump tokio to 1.52.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| serde_test = "1.0.167" | ||
| tempfile = "3.22" | ||
| tokio = { version = "1.50.0", features = ["full", "test-util", "tracing"] } | ||
| tokio = { version = "1.52.1", features = ["full", "test-util", "tracing"] } |
There was a problem hiding this comment.
tokio is now specified as 1.52.1 under [dev-dependencies], but this crate still declares tokio = { version = "1.47.1", ... } under [dependencies]. Even though Cargo can unify these via caret requirements, keeping different minimum versions in the same manifest is confusing and can lead to unexpected resolution differences across build modes. Consider bumping the [dependencies] entry to 1.52.1 as well (or otherwise aligning the version specs).
| perthread = { version = "0.1.0", path = "../perthread" } | ||
| stats_traits = { version = "0.1.0", path = "traits" } | ||
| tokio = { version = "1.50.0", features = ["full", "test-util", "tracing"] } | ||
| tokio = { version = "1.52.1", features = ["full", "test-util", "tracing"] } |
There was a problem hiding this comment.
PR description says this change upgrades tokio from 1.50.0 to 1.52.1, but the repo still has manifests with older tokio requirements (e.g. eden/fs/cli_rs/edenfs-client depends on 1.47.1, and watchman/rust/watchman_client depends on 1.45). Please either expand this PR to update the remaining manifests, or clarify in the description that only the 1.50.0 pins are being updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookincubator/below#8278
X-link: https://github.com/facebookexperimental/dapper/pull/1
X-link: meta-pytorch/monarch#3495
Upgrading
tokiofrom1.50.0to1.52.1.Reviewed By: dtolnay
Differential Revision: D101580193