Fix typos, stale paths, and mismatched param names in docstrings and comments#4914
Closed
saitcakmak wants to merge 2 commits intofacebook:mainfrom
Closed
Fix typos, stale paths, and mismatched param names in docstrings and comments#4914saitcakmak wants to merge 2 commits intofacebook:mainfrom
saitcakmak wants to merge 2 commits intofacebook:mainfrom
Conversation
…acebook#4913) Summary: `abc.abstractproperty` has been deprecated since Python 3.3 in favor of stacking `property` and `abstractmethod` decorators. This replaces all remaining usages across 4 files in the Ax codebase. Reviewed By: Balandat Differential Revision: D93279592
…comments Summary: Fix documentation issues across Ax: - Fix doubled-word typos and missing spaces in comments. - Fix stale file paths and mismatched parameter names in docstrings. - Fix miscellaneous spelling errors in docstrings and comments. Reviewed By: Balandat Differential Revision: D93525937
meta-cla
bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93525937. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4914 +/- ##
==========================================
- Coverage 96.80% 96.80% -0.01%
==========================================
Files 595 595
Lines 63111 63122 +11
==========================================
+ Hits 61095 61105 +10
- Misses 2016 2017 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in 4b89d30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix documentation issues across Ax:
Reviewed By: Balandat
Differential Revision: D93525937