Merged
Conversation
Contributor
|
I agree with limiting the number of retries with exponential backoff, but we should not remove retries altogether. Often I have run into situations where the instance fails the first time then succeeds after a retry (particularly common with RDMA). |
ciaranbor
force-pushed
the
ciaran/remove-instance-retry
branch
6 times, most recently
from
2d32a29 to
384f830
Compare
Evanev7
force-pushed
the
ciaran/remove-instance-retry
branch
from
384f830 to
383ed31
Compare
Evanev7
force-pushed
the
ciaran/remove-instance-retry
branch
from
383ed31 to
7b26e19
Compare
Evanev7
added a commit
that referenced
this pull request
Apr 9, 2026
extension to #1763 that prevents crash looping in some common scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when a runner fails, the master retries the instance. Most of the time, this causes a loop over failure. Retries need backoff and a cap.
Changes
Why It Works
The worker gates CreateRunner tasks behind a KeyedBackoff, adding exponential delay (2s base, 30s cap) between retries. After 3 failures the worker sends DeleteInstance, stopping retries entirely. The backoff resets when the instance is deleted, so a fresh placement starts clean.