-
-
Notifications
You must be signed in to change notification settings - Fork 35
Migrate from Spago 0.21.0 to Spago 1.0.3 #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2c14205
Migrate from Spago 0.21.0 (Dhall) to Spago 1.0.3 (YAML + Registry)
FranklinChen 6df769a
Pin setup-node action to the commit SHA.
FranklinChen cc04714
Use [[ ]] instead of [ ].
FranklinChen 1271450
Collect all failures. Clean up node_modules. Use paths for practice v…
FranklinChen d7fd062
Oops, forgot to add st as intended.
FranklinChen 0de23da
Improve Bash code.
FranklinChen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,21 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # This script will update spago.dhall and package.dhall of all exercises | ||
| # This script will update spago.yaml and .gitignore of all exercises | ||
| # using the master files from the project template (template/). | ||
|
|
||
| set -e | ||
| set -o pipefail | ||
| set -u | ||
|
|
||
| base_dir=$(builtin cd "${BASH_SOURCE%/*}/.." || exit; pwd) | ||
| exercises_dir="${base_dir}/exercises" | ||
| template_dir="${base_dir}/template" | ||
|
|
||
| for config in "$exercises_dir"/*/*/spago.dhall; do | ||
| exercise_dir=$(dirname "${config}") | ||
| slug=$(basename "${exercise_dir}") | ||
| for exercise_dir in "$base_dir"/exercises/*/*/; do | ||
| exercise_dir="${exercise_dir%/}" | ||
| slug="${exercise_dir##*/}" | ||
|
|
||
| echo "Working in ${exercise_dir}..." | ||
|
|
||
| sed -e "s/exercise-template/${slug}/" < "${template_dir}/spago.dhall" > "${exercise_dir}/spago.dhall" | ||
| cp "${template_dir}/packages.dhall" "${exercise_dir}/packages.dhall" | ||
| sed -e "s/exercise-template/${slug}/" < "${template_dir}/spago.yaml" > "${exercise_dir}/spago.yaml" | ||
| cp "${template_dir}/.gitignore" "${exercise_dir}/.gitignore" | ||
| done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| /bower_components/ | ||
| /node_modules/ | ||
| /.pulp-cache/ | ||
| /output/ | ||
| /generated-docs/ | ||
| /.psc-package/ | ||
| /.psc* | ||
| /.purs* | ||
| /.psa* | ||
| /.spago | ||
| /.spago/ | ||
| /spago.lock | ||
| /.purs-repl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package: | ||
| name: annalyns-infiltration | ||
| dependencies: | ||
| - arrays | ||
| - console | ||
| - datetime | ||
| - effect | ||
| - either | ||
| - enums | ||
| - exceptions | ||
| - foldable-traversable | ||
| - integers | ||
| - lists | ||
| - maybe | ||
| - numbers | ||
| - ordered-collections | ||
| - partial | ||
| - prelude | ||
| - psci-support | ||
| - st | ||
| - strings | ||
| - test-unit | ||
| - tuples | ||
| - unfoldable | ||
| - unicode | ||
| test: | ||
| main: Test.Main | ||
| dependencies: [] | ||
| workspace: | ||
| packageSet: | ||
| registry: 73.0.0 | ||
| extraPackages: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| /bower_components/ | ||
| /node_modules/ | ||
| /.pulp-cache/ | ||
| /output/ | ||
| /generated-docs/ | ||
| /.psc-package/ | ||
| /.psc* | ||
| /.purs* | ||
| /.psa* | ||
| /.spago | ||
| /.spago/ | ||
| /spago.lock | ||
| /.purs-repl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package: | ||
| name: accumulate | ||
| dependencies: | ||
| - arrays | ||
| - console | ||
| - datetime | ||
| - effect | ||
| - either | ||
| - enums | ||
| - exceptions | ||
| - foldable-traversable | ||
| - integers | ||
| - lists | ||
| - maybe | ||
| - numbers | ||
| - ordered-collections | ||
| - partial | ||
| - prelude | ||
| - psci-support | ||
| - st | ||
| - strings | ||
| - test-unit | ||
| - tuples | ||
| - unfoldable | ||
| - unicode | ||
| test: | ||
| main: Test.Main | ||
| dependencies: [] | ||
| workspace: | ||
| packageSet: | ||
| registry: 73.0.0 | ||
| extraPackages: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| /bower_components/ | ||
| /node_modules/ | ||
| /.pulp-cache/ | ||
| /output/ | ||
| /generated-docs/ | ||
| /.psc-package/ | ||
| /.psc* | ||
| /.purs* | ||
| /.psa* | ||
| /.spago | ||
| /.spago/ | ||
| /spago.lock | ||
| /.purs-repl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package: | ||
| name: acronym | ||
| dependencies: | ||
| - arrays | ||
| - console | ||
| - datetime | ||
| - effect | ||
| - either | ||
| - enums | ||
| - exceptions | ||
| - foldable-traversable | ||
| - integers | ||
| - lists | ||
| - maybe | ||
| - numbers | ||
| - ordered-collections | ||
| - partial | ||
| - prelude | ||
| - psci-support | ||
| - st | ||
| - strings | ||
| - test-unit | ||
| - tuples | ||
| - unfoldable | ||
| - unicode | ||
| test: | ||
| main: Test.Main | ||
| dependencies: [] | ||
| workspace: | ||
| packageSet: | ||
| registry: 73.0.0 | ||
| extraPackages: {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,5 @@ | ||
| /bower_components/ | ||
| /node_modules/ | ||
| /.pulp-cache/ | ||
| /output/ | ||
| /generated-docs/ | ||
| /.psc-package/ | ||
| /.psc* | ||
| /.purs* | ||
| /.psa* | ||
| /.spago | ||
| /.spago/ | ||
| /spago.lock | ||
| /.purs-repl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there a per-exercise
.gitignorevs a common one at the root?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea to have exercise-scoped .gitignore because if someone downloads an independent exercise, we don't know what context it might exist in, as someone could want to work on an exercise within their own Git repo, so being self-contained guarantees that the right things will be ignored.
BTW, this PR is a mess because I screwed things up, so I'm preparing to address other stuff and create a new PR when I'm ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant, the test runner one, where I have a new one exercism/purescript-test-runner#64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None (or very few) of the other tracks use per-exercise
.gitignores. If the user is checking in their code, would it make sense to let them manage their own.gitignore?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think packaging directories with their own scoped .gitignore is the best way to go, and that it's a mistake that it's not a standard practice throughout Exercism.