Skip to content

✨ server: add bank beneficiary address to deposit details #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cruzdanilo merged 1 commit into from
Mar 18, 2026
Merged

✨ server: add bank beneficiary address to deposit details #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cohk-ogyn-nhcy.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@exactly/server": patch
---

✨ add bank beneficiary address to deposit details
2 changes: 2 additions & 0 deletions server/api/ramp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ const DepositDetails = variant("network", [
accountNumber: string(),
bankName: string(),
bankAddress: string(),
beneficiaryAddress: string(),
fee: string(),
estimatedProcessingTime: string(),
}),
Expand All @@ -286,6 +287,7 @@ const DepositDetails = variant("network", [
accountNumber: string(),
bankAddress: string(),
bankName: string(),
beneficiaryAddress: string(),
fee: string(),
estimatedProcessingTime: string(),
}),
Expand Down
4 changes: 4 additions & 0 deletions server/test/api/ramp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ describe("ramp api", () => {
routingNumber: "987654321",
accountNumber: "123456789",
bankAddress: "123 Test St",
beneficiaryAddress: "456 Beneficiary Ave",
bankName: "Test Bank",
fee: "0.0",
estimatedProcessingTime: "1 - 3 business days",
Expand All @@ -274,6 +275,7 @@ describe("ramp api", () => {
routingNumber: "987654321",
accountNumber: "123456789",
bankAddress: "123 Test St",
beneficiaryAddress: "456 Beneficiary Ave",
bankName: "Test Bank",
fee: "0.0",
estimatedProcessingTime: "300",
Expand All @@ -297,6 +299,7 @@ describe("ramp api", () => {
routingNumber: "987654321",
accountNumber: "123456789",
bankAddress: "123 Test St",
beneficiaryAddress: "456 Beneficiary Ave",
bankName: "Test Bank",
fee: "0.0",
estimatedProcessingTime: "1 - 3 business days",
Expand All @@ -308,6 +311,7 @@ describe("ramp api", () => {
routingNumber: "987654321",
accountNumber: "123456789",
bankAddress: "123 Test St",
beneficiaryAddress: "456 Beneficiary Ave",
bankName: "Test Bank",
fee: "0.0",
estimatedProcessingTime: "300",
Expand Down
2 changes: 2 additions & 0 deletions server/test/utils/bridge.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,7 @@ describe("bridge utils", () => {
routingNumber: "111000025",
accountNumber: "000123456789",
bankAddress: "123 Bank St",
beneficiaryAddress: "456 Beneficiary Ave",
bankName: "Test Bank",
fee: "0.0",
estimatedProcessingTime: "1 - 3 business days",
Expand All @@ -774,6 +775,7 @@ describe("bridge utils", () => {
routingNumber: "111000025",
accountNumber: "000123456789",
bankAddress: "123 Bank St",
beneficiaryAddress: "456 Beneficiary Ave",
bankName: "Test Bank",
fee: "0.0",
estimatedProcessingTime: "300",
Expand Down
2 changes: 2 additions & 0 deletions server/utils/ramps/bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,6 +900,7 @@ function getDepositDetailsFromVirtualAccount(virtualAccount: InferOutput<typeof
routingNumber: virtualAccount.source_deposit_instructions.bank_routing_number,
accountNumber: virtualAccount.source_deposit_instructions.bank_account_number,
bankAddress: virtualAccount.source_deposit_instructions.bank_address,
beneficiaryAddress: virtualAccount.source_deposit_instructions.bank_beneficiary_address,
bankName: virtualAccount.source_deposit_instructions.bank_name,
fee: "0.0",
estimatedProcessingTime: "1 - 3 business days",
Expand All @@ -911,6 +912,7 @@ function getDepositDetailsFromVirtualAccount(virtualAccount: InferOutput<typeof
routingNumber: virtualAccount.source_deposit_instructions.bank_routing_number,
accountNumber: virtualAccount.source_deposit_instructions.bank_account_number,
bankAddress: virtualAccount.source_deposit_instructions.bank_address,
beneficiaryAddress: virtualAccount.source_deposit_instructions.bank_beneficiary_address,
bankName: virtualAccount.source_deposit_instructions.bank_name,
fee: "0.0",
estimatedProcessingTime: "300",
Expand Down
Loading