Conversation
cruzdanilo
requested review from
dieguezguille,
franm91,
itofarina and
nfmelendez
as code owners
🦋 Changeset detectedLatest commit: 94ee9db The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR SummaryMedium Risk Overview Modernizes build tooling and workflows: bumps Node to Contracts/dev tooling adjustments: updates OpenZeppelin + Written by Cursor Bugbot for commit 9ba9e88. This will update automatically on new commits. Configure here. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBulk dependency and CI/tooling upgrades, Expo/OneSignal app.config edits, a metro web timer patch, ERC1967Proxy inline initialization in contract tests, protocol address reindexing in test harness/server, and multiple small UI style and theme/logic tweaks. Changes
Sequence Diagram(s)sequenceDiagram
participant Test as Test harness (Protocol.s.sol)
participant EVM as EVM / Anvil
participant Proxy as ERC1967Proxy (constructor)
participant Impl as Contract implementation
Test->>EVM: deploy Impl (new Impl)
Test->>EVM: create ERC1967Proxy(address(new Impl...), abi.encodeCall(Impl.initialize,args))
EVM->>Proxy: create proxy with impl address + init calldata
Proxy->>Impl: delegatecall initialize(calldata) during proxy creation
Impl-->>Proxy: initialization completes (state set)
Test->>EVM: run post-deploy setup calls (setInterestRateModel, enableMarket, label)
EVM-->>Test: deployment and setup complete
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a comprehensive upgrade of project dependencies across all modules, ensuring the codebase remains current with the latest library versions. It includes updates to core frameworks like Expo and React Native, various development tools, and smart contract-related packages. Additionally, minor refinements have been made to contract deployment logic, build configurations, and UI styling to enhance stability and maintainability. Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Prevent Tests Dashboard |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
cruzdanilo
force-pushed
the
upgrade
branch
2 times, most recently
from
6cb9a05 to
3f2a415
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
🚩 peerDependencyRules overhaul removes blanket TypeScript override
The old peerDependencyRules had "allowedVersions": { "typescript": "$typescript" } which silenced all TypeScript peer dependency mismatches, plus "ignoreMissing" for hardhat, hono-rate-limiter, and typechain. The new config removes both, replacing them with targeted allowedVersions for specific dependency paths (e.g., "@hono/mcp>hono-rate-limiter": "0.5"). This is paired with the broadened override "typescript@5": "catalog:" (previously "typescript@5.8.3": "catalog:"). If any transitive dependency still requires the missing peer deps or has a TypeScript version mismatch not covered by the override, pnpm install will emit warnings.
Was this helpful? React with 👍 or 👎 to provide feedback.
| { | ||
| Auditor: 1, | ||
| Firewall: 37, | ||
| MarketUSDC: 13, | ||
| MarketWETH: 21, | ||
| IntegrationPreviewer: 33, | ||
| Previewer: 32, | ||
| RatePreviewer: 34, | ||
| USDC: 11, | ||
| WETH: 19, | ||
| Firewall: 33, | ||
| MarketUSDC: 11, | ||
| MarketWETH: 18, | ||
| IntegrationPreviewer: 29, | ||
| Previewer: 28, | ||
| RatePreviewer: 30, | ||
| USDC: 9, | ||
| WETH: 16, | ||
| }[contract] ?? Infinity |
There was a problem hiding this comment.
🚩 Balancer2Vault not in wagmi loadDeployment index map for anvil
Pre-existing: loadDeployment("Balancer2Vault", false) at common/wagmi.config.ts:29 looks up Balancer2Vault in the index map at line 200-210, but Balancer2Vault is not present. This means the lookup falls through to Infinity, returning undefined. Since it's optional (required = false), this results in balancerVaultAddress being undefined in the generated chain.ts for anvil builds. The MockBalancerVault IS deployed at transaction index 23 in the Protocol script, so the address exists but isn't being picked up by wagmi config generation for anvil. This was the same in the old code (where the index would have been 27).
Was this helpful? React with 👍 or 👎 to provide feedback.
dieguezguille
force-pushed
the
payments
branch
4 times, most recently
from
3b08235 to
8ea1a40
Compare
2 participants
closes #853
Summary by CodeRabbit
Chores
Bug Fixes
Configuration