Skip to content

Conversation

@jonas089
Copy link

The Interop team needs to import portions of the evolve code into the SP1 context to address recent changes in FeeHandler.

To enable this, several default features were disabled on specific crates to ensure no C-deps are pulled in, which can't be compiled by the SP1 toolchain.

@jonas089 jonas089 requested a review from a team as a code owner January 26, 2026 17:39
@jonas089 jonas089 changed the title Chore: Disable default features on some crates to unblock SP1 work chore: Disable default features on some crates to unblock SP1 work Jan 26, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jonas089, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request facilitates the integration of evolve code into the SP1 context by modifying crate dependencies. Specifically, it disables default features for several reth and alloy related crates, and adjusts alloy's version and features, to prevent the inclusion of C-dependencies that are incompatible with the SP1 toolchain. This ensures that the evolve code can be compiled and utilized within the SP1 environment without native library conflicts.

Highlights

  • Dependency Feature Management: Disabled default features for several reth and alloy related crates (reth-transaction-pool, reth-e2e-test-utils, reth-evm, reth-evm-ethereum, reth-primitives, reth-revm, alloy, revm-inspector) to prevent the inclusion of C-dependencies.
  • Alloy Crate Version and Features: Downgraded the alloy crate to version 1.0.37 and adjusted its enabled features to ["contract", "sol-types"], while also disabling its default features.
  • Removed C-Dependency: The c-kzg dependency was removed from reth in Cargo.lock, further reducing native library requirements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully addresses the stated objective of disabling default features on specific crates to avoid C-dependencies, which is necessary for compatibility with the SP1 toolchain. The modifications in Cargo.toml accurately reflect these changes, and the Cargo.lock file has been updated accordingly.

Comment on lines +89 to +92
alloy = { version = "=1.0.37", default-features = false, features = [
"contract",
"providers",
"provider-http",
"signers",
"reqwest-rustls-tls",
], default-features = false }
"sol-types",
] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The alloy dependency's feature set has been significantly reduced from ["contract", "providers", "provider-http", "signers", "reqwest-rustls-tls"] to ["contract", "sol-types"]. While this aligns with the goal of removing C-dependencies, please ensure that the removed features (especially providers, provider-http, and signers) are not implicitly relied upon by other parts of the evolve code within the SP1 context. If any functionality is missing, it might lead to runtime errors or unexpected behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant