Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 23, 2026

Bumps the go_modules group with 1 update in the /execution/evm/test directory: github.com/cometbft/cometbft.

Updates github.com/cometbft/cometbft from 0.38.20 to 0.38.21

Release notes

Sourced from github.com/cometbft/cometbft's releases.

v0.38.21

What's Changed

Full Changelog: cometbft/cometbft@v0.38.20...v0.38.21

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps the go_modules group with 1 update in the /execution/evm/test directory: [github.com/cometbft/cometbft](https://github.com/cometbft/cometbft).


Updates `github.com/cometbft/cometbft` from 0.38.20 to 0.38.21
- [Release notes](https://github.com/cometbft/cometbft/releases)
- [Changelog](https://github.com/cometbft/cometbft/blob/main/CHANGELOG.md)
- [Commits](cometbft/cometbft@v0.38.20...v0.38.21)

---
updated-dependencies:
- dependency-name: github.com/cometbft/cometbft
  dependency-version: 0.38.21
  dependency-type: indirect
  dependency-group: go_modules
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Jan 23, 2026
@github-actions
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow CI / buf-check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJan 26, 2026, 10:12 AM

@claude
Copy link
Contributor

claude bot commented Jan 26, 2026

Claude finished @dependabot[bot]'s task in 1m 48s —— View job


Comprehensive Code Review

Overview

This PR bumps github.com/cometbft/cometbft from v0.38.20 to v0.38.21 in two test directories:

  • execution/evm/test/
  • test/e2e/

Tasks

  • Read changed files to understand dependency update
  • Review CometBFT release notes and changelog
  • Check for potential breaking changes or impacts
  • Verify go.mod/go.sum consistency
  • Provide comprehensive code review feedback

Code Review Findings

Dependency Update Analysis

What Changed:

  • CometBFT v0.38.20 → v0.38.21 (patch version bump)
  • This is an indirect dependency (marked with // indirect in go.mod)
  • Updated in 4 files: execution/evm/test/go.{mod,sum} and test/e2e/go.{mod,sum}

Release Contents (from v0.38.21):

  1. Configuration enhancement: Added max snapshot chunks configuration for state sync
  2. Test improvements: Added unit tests for TotalVotingPowerSafe
  3. Bug fixes: Test case fixes and validation improvements

Impact Assessment:

  • No breaking changes: This is a patch release with backward-compatible improvements
  • Low risk: Changes are primarily test enhancements and configuration options
  • Indirect dependency: CometBFT is pulled in transitively through cosmos-sdk and celestiaorg/tastora

Code Quality & Architecture

go.mod/go.sum Consistency:

  • ✅ Changes are correctly synchronized across both directories
  • ✅ Hash updates in go.sum match the new version
  • ✅ Module import paths remain unchanged
  • ✅ No unrelated dependencies were modified

Dependency Chain:

execution/evm/test:
  └─ cosmos-sdk v0.50.15 (indirect) 
     └─ cometbft v0.38.21 (indirect)
  └─ celestiaorg/tastora v0.8.0
     └─ cometbft v0.38.21 (indirect)

test/e2e:
  └─ cosmos-sdk v0.53.5
     └─ cometbft v0.38.21 (indirect)
  └─ celestiaorg/tastora v0.9.0
     └─ cometbft v0.38.21 (indirect)

Observation: CometBFT is not directly imported in the codebase - it's a transitive dependency. The update was likely pulled in by the parent dependencies.


Security

Security Assessment:

  • ✅ No known security vulnerabilities addressed in this release
  • ✅ No CVEs listed in the release notes
  • ✅ Patch version bump suggests routine maintenance
  • ✅ Changes are limited to configuration and testing improvements

Recommendation: This is a safe update from a security perspective.


Testing & Reliability

Test Coverage:

  • ✅ The update includes additional unit tests in upstream (TotalVotingPowerSafe coverage)
  • ✅ CI checks are running (buf-check passed, other checks in progress)
  • ⏳ Waiting for full CI pipeline to complete

Testing Recommendation:
Since this affects test modules specifically, verify:

  1. make test - All unit tests pass
  2. make test-integration - Integration tests complete successfully
  3. make test-e2e - End-to-end tests work correctly

Performance & Resource Efficiency

Performance Impact:

  • ✅ Minimal to no performance impact expected
  • ✅ New configuration option (max snapshot chunks) provides better control over resource usage during state sync
  • ✅ No changes to hot paths or core consensus logic

Documentation & Developer Experience

Documentation:

  • ✅ Dependabot PR includes clear release notes
  • ✅ Changes are well-documented in upstream repository
  • ✅ Compatibility score indicates this is a safe update

Summary & Recommendation

Overall Assessment: ✅ APPROVE

This is a routine, low-risk patch update that:

  1. ✅ Adds configuration flexibility for state sync
  2. ✅ Improves test coverage in upstream
  3. ✅ Contains no breaking changes
  4. ✅ Maintains go.mod/go.sum consistency
  5. ✅ Follows semantic versioning appropriately

Action Items:

  • Merge after CI passes: This PR is safe to merge once all CI checks complete successfully
  • 📋 Monitor CI results: Ensure all tests pass (particularly integration and e2e tests)
  • No code changes needed: The dependency update is complete and correct

Final Verdict: This is a well-formed Dependabot PR that follows best practices. The CometBFT patch release is safe to adopt.


@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.89%. Comparing base (9a91394) to head (dc824af).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3011      +/-   ##
==========================================
- Coverage   57.99%   57.89%   -0.11%     
==========================================
  Files         110      110              
  Lines       10526    10526              
==========================================
- Hits         6105     6094      -11     
- Misses       3770     3781      +11     
  Partials      651      651              
Flag Coverage Δ
combined 57.89% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@julienrbrt julienrbrt added this pull request to the merge queue Jan 26, 2026
Merged via the queue into main with commit 95953fd Jan 26, 2026
28 checks passed
@julienrbrt julienrbrt deleted the dependabot/go_modules/execution/evm/test/go_modules-bae0d973bf branch January 26, 2026 10:37
alpe added a commit that referenced this pull request Jan 26, 2026
* main:
  fix(docs): remove blog link from sidebar to fix 404 (#3014)
  build(deps): Bump github.com/cometbft/cometbft from 0.38.20 to 0.38.21 in /execution/evm/test in the go_modules group across 1 directory (#3011)
  refactor: use slices.Contains to simplify code (#3010)
  chore: Bump mermaid version and dependencies (#3009)
  chore: Bump github.com/consensys/gnark-crypto only (#3008)
  test: evm contract interaction (#3006)
  chore: remove redundant log (#3007)
  fix: return values correctly not nil (#3004)
  feat: expose execution client params to ev-node (#2982)
alpe added a commit that referenced this pull request Jan 26, 2026
* main:
  fix(docs): remove blog link from sidebar to fix 404 (#3014)
  build(deps): Bump github.com/cometbft/cometbft from 0.38.20 to 0.38.21 in /execution/evm/test in the go_modules group across 1 directory (#3011)
  refactor: use slices.Contains to simplify code (#3010)
  chore: Bump mermaid version and dependencies (#3009)
  chore: Bump github.com/consensys/gnark-crypto only (#3008)
  test: evm contract interaction (#3006)
  chore: remove redundant log (#3007)
  fix: return values correctly not nil (#3004)
  feat: expose execution client params to ev-node (#2982)
  feat(tracing): HTTP propagation (#3000)
  fix: deploy docs token (#3003)
  feat(tracing): add store tracing (#3001)
  feat: p2p exchange wrapper  (#2855)
  build(deps): Bump the all-go group across 5 directories with 5 updates (#2999)
  feat(tracing): adding forced inclusion tracing (#2997)
  chore: update calculator for strategies  (#2995)
  chore: adding tracing for da submitter (#2993)
  feat(tracing): part 10 da retriever tracing (#2991)
  chore: add da posting strategy to docs (#2992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants