Skip to content

Conversation

@everoddandeven
Copy link
Owner

@everoddandeven everoddandeven commented Jan 29, 2026

Basic wallet txs test

  • Add test TestMoneroWalletCommon.test_get_txs_wallet
  • Fund wallet before running tests
  • Refactory TestUtils
  • Add MoneroTxWallet.get_incoming_amount, MoneroTxWallet.get_outgoing_amount, MoneroTxWallet.get_inputs_wallet
  • Fix PyMoneroWalletRpc::get_accounts

@everoddandeven everoddandeven changed the title Txs implementation and tests Basic wallet txs test Jan 30, 2026
@codacy-production
Copy link

codacy-production bot commented Jan 30, 2026

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.13% (target: -1.00%) 69.37%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (94b2629) 11972 7379 61.64%
Head commit (92f518f) 12784 (+812) 7863 (+484) 61.51% (-0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#43) 2034 1411 69.37%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@everoddandeven everoddandeven marked this pull request as ready for review January 30, 2026 23:09
@everoddandeven everoddandeven merged commit b3ee7b6 into main Jan 30, 2026
4 of 5 checks passed
@everoddandeven everoddandeven deleted the rpc-txs-implementation branch January 30, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants