ENG-2828: Disable delete button on default DSR policies

[gilluminate]

Ticket ENG-2828

Description Of Changes

Disable the delete button on default DSR policies (both the list page and detail page) by fetching the default policy keys from the /api/v1/plus/dsr/policy/default endpoint. Default policies display a disabled delete button with a tooltip explaining "Default policies cannot be deleted". Non-default policies are unaffected.

Also:

• Removes the unnecessary <span> wrapper around disabled <Tooltip> buttons in MonitorConfigTab (Ant Design handles this natively)
• Replaces the temporary startsWith("default_") sorting heuristic with the endpoint data

Code Changes

• clients/admin-ui/src/features/policies/policy.slice.ts - Added getDefaultPolicies RTK Query endpoint for GET /plus/dsr/policy/default
• clients/admin-ui/src/features/policies/constants.ts - New shared DEFAULT_POLICY_TOOLTIP constant
• clients/admin-ui/src/features/policies/PolicyBox.tsx - Added isDefault prop; disables delete button with tooltip when true
• clients/admin-ui/src/pages/privacy-request-policies/index.tsx - Fetch default policy keys, disable delete on defaults, use endpoint data for sorting
• clients/admin-ui/src/pages/privacy-request-policies/[key].tsx - Fetch default policy keys, pass isDefault to PolicyBox
• clients/admin-ui/src/features/integrations/configure-monitor/MonitorConfigTab.tsx - Remove unnecessary <span> wrapper for Tooltip on disabled button
• clients/admin-ui/cypress/support/stubs.ts - Stub the default policies endpoint
• clients/admin-ui/cypress/fixtures/policies/list.json - Added non-default custom policy fixture
• clients/admin-ui/cypress/e2e/policies/policies-list.cy.ts - Tests for disabled delete on default policies
• clients/admin-ui/cypress/e2e/policies/policy-crud.cy.ts - Updated delete tests to use non-default policy
• clients/admin-ui/cypress/e2e/policies/policy-detail.cy.ts - Tests for disabled delete on detail page

Steps to Confirm

1. Navigate to the DSR Policies list page
2. Verify default policies (Default Access, Erasure, Consent) have disabled delete buttons
3. Hover over a disabled delete button and confirm the tooltip "Default policies cannot be deleted" appears
4. Verify non-default policies still have an enabled, clickable delete button
5. Navigate to a default policy's detail page and confirm the delete button is disabled with tooltip
6. Navigate to a non-default policy's detail page and confirm delete works normally

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated
• UX feedback:
  • All UX related changes have been reviewed by a designer
• Followup issues:
  • No followup issues
• Database migrations:
  • No migrations
• Documentation:
  • No documentation updates required

Made with Cursor

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Feb 28, 2026 1:14am

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Feb 28, 2026 1:14am

[greptile-apps]

Greptile Summary

This PR successfully implements protection for default DSR policies by disabling their delete buttons with explanatory tooltips.

Key Changes

• Added getDefaultPolicies RTK Query endpoint to fetch default policy keys from /plus/dsr/policy/default
• Conditionally disabled delete buttons on both list and detail pages for default policies (Access, Erasure, Consent)
• Replaced temporary startsWith("default_") sorting heuristic with actual endpoint data
• Added DEFAULT_POLICY_TOOLTIP constant for consistent messaging across components
• Comprehensive test coverage for the new functionality

Observations

The implementation follows Ant Design patterns correctly and uses proper React patterns (useMemo for derived state). The code gracefully handles missing data by defaulting to treating policies as deletable, which is appropriate since the backend should also validate deletion attempts.

The PR includes an unrelated cleanup in MonitorConfigTab.tsx (removing unnecessary <span> wrapper around Tooltip), which while beneficial, is outside the scope of the main feature.

Confidence Score: 4/5

• This PR is safe to merge with minor observations about error handling
• Clean implementation with good test coverage. The code follows existing patterns and uses proper React/RTK Query conventions. Minor deduction for lack of explicit error handling on the default policies query (though the implicit fail-open behavior is acceptable) and an unrelated cleanup change in MonitorConfigTab.
• The two page files (index.tsx and [key].tsx) don't explicitly handle errors from useGetDefaultPoliciesQuery(), but this is acceptable since they fail open (treating policies as deletable) and the backend should validate.

Important Files Changed

Filename	Overview
clients/admin-ui/src/features/policies/policy.slice.ts	Added getDefaultPolicies RTK Query endpoint to fetch default policy keys from /plus/dsr/policy/default. Endpoint correctly uses providesTags for cache management.
clients/admin-ui/src/features/policies/constants.ts	Added shared constant DEFAULT_POLICY_TOOLTIP for consistent tooltip messaging across components. Follows custom rule for defining magic strings as named variables.
clients/admin-ui/src/features/policies/PolicyBox.tsx	Added isDefault prop to conditionally disable delete button with tooltip. Implementation correctly uses Ant Design Tooltip pattern with disabled buttons.
clients/admin-ui/src/pages/privacy-request-policies/index.tsx	Fetches default policies and conditionally disables delete buttons. Replaces startsWith heuristic with API data. No explicit error handling for default policies query - silently treats all policies as deletable on failure.
clients/admin-ui/src/pages/privacy-request-policies/[key].tsx	Fetches default policies to determine if current policy is default. Passes isDefault to PolicyBox. No explicit error handling - defaults to false (deletable) on query failure.

_{Last reviewed commit: 14416a2}

[greptile-apps]

_{12 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}