Okta Monitor UX: logos, descriptions, type tags, Add→Approve#7490
Okta Monitor UX: logos, descriptions, type tags, Add→Approve#7490Kelsey-Ethyca wants to merge 83 commits intorelease-2.79.0from
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
#7381) Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Eliana Rosselli <67162025+erosselli@users.noreply.github.com>
Co-authored-by: Adrian Galvan <galvana@uci.edu>
Co-authored-by: Adrian Galvan <adrian@ethyca.com> Co-authored-by: Adrian Galvan <galvana@uci.edu>
Co-authored-by: Jade Wibbels <jade@ethyca.com> Co-authored-by: Cursor <cursoragent@cursor.com>
… legal sources (#7356) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Jade Wibbels <jade@ethyca.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…ies schema (#7395) Co-authored-by: Jade Wibbels <jade@ethyca.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…custom ID on preferences (#7094) Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Jason Gill <jason.gill@ethyca.com> Co-authored-by: Neville Samuell <NevilleS@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ation (#7345) Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Neville Samuell <NevilleS@users.noreply.github.com> Co-authored-by: Adrian Galvan <adrian@ethyca.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…7384) Co-authored-by: Jade Wibbels <jade@ethyca.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…7388) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Eliana Rosselli <67162025+erosselli@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…tion (#7467) Co-authored-by: Cursor <cursoragent@cursor.com>
…nfig (#7472) Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: jpople <jeremy@ethyca.com>
…d→Approve - Enable BrandFetch logo integration for infrastructure system list items (uncomment ENG-2391 code for vendor logo URL resolution and Avatar display) - Show system descriptions as secondary text below system names - Add monitor type tag (IDP/Web/Datastore) on MonitorResult in activity center - Change "Add" terminology to "Approve" across all action cells and bulk menus Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR enhances the Okta Monitor UX with four main improvements: vendor logos via BrandFetch, system descriptions, monitor type tags, and renaming "Add" to "Approve" throughout the UI. Key Changes:
Implementation Quality:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: cac8faa |
| )} | ||
| </Flex> | ||
| {item.description && ( | ||
| <Text type="secondary" className="text-xs pl-1"> |
There was a problem hiding this comment.
The text-xs tailwind class is used for font sizing. Per the frontend style guide, tailwind should only be used for layout and animation, not for typography sizing. Consider using Ant Design's Text component size prop or FidesUI palette/theme styling instead.
Context Used: Context from dashboard - Front-end developer rules (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: jpople <jeremy@ethyca.com> Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: jpople <jeremy@ethyca.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Made-with: Cursor
Summary
vendor_logo_url, falls back to BrandFetch CDN via vendor_id/system name, then to a generic settings icon.item.descriptionas secondary text below each system name in the infrastructure list, giving non-technical users context about what each system does.Test plan
🤖 Generated with Claude Code