Skip to content

Okta Monitor UX: logos, descriptions, type tags, Add→Approve#7490

Draft
Kelsey-Ethyca wants to merge 83 commits intorelease-2.79.0from
KT-Okta
Draft

Okta Monitor UX: logos, descriptions, type tags, Add→Approve#7490
Kelsey-Ethyca wants to merge 83 commits intorelease-2.79.0from
KT-Okta

Conversation

@Kelsey-Ethyca
Copy link
Contributor

Summary

  • BrandFetch logos: Enabled vendor logo resolution for infrastructure system list items (previously commented out behind ENG-2391). Shows logos from metadata vendor_logo_url, falls back to BrandFetch CDN via vendor_id/system name, then to a generic settings icon.
  • System descriptions: Added display of item.description as secondary text below each system name in the infrastructure list, giving non-technical users context about what each system does.
  • Monitor type tag: Added a tag (IDP / Web / Datastore) next to each monitor name in the activity center list, so users can quickly identify the integration type.
  • Add → Approve: Changed all "Add" button labels and tooltips to "Approve" across individual action cells, bulk action menus, and tooltip messages — making it clearer that the action is approval, not creation.

Test plan

  • Verify BrandFetch logos load correctly for known vendors in the Okta monitor system list
  • Verify fallback to settings gear icon when no logo is available
  • Verify system descriptions appear below system names when available
  • Verify monitor type tags (IDP, Web, Datastore) appear on the activity center monitor list
  • Verify "Approve" label appears on individual system action buttons
  • Verify "Approve" label appears in bulk actions dropdown menus
  • Verify tooltip messages reference "approve" instead of "add"

🤖 Generated with Claude Code

NevilleS and others added 30 commits February 12, 2026 09:38
Co-authored-by: Cursor <cursoragent@cursor.com>
#7381)

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: Eliana Rosselli <67162025+erosselli@users.noreply.github.com>
Co-authored-by: Adrian Galvan <galvana@uci.edu>
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Co-authored-by: Adrian Galvan <galvana@uci.edu>
Co-authored-by: Jade Wibbels <jade@ethyca.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
… legal sources (#7356)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Jade Wibbels <jade@ethyca.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…ies schema (#7395)

Co-authored-by: Jade Wibbels <jade@ethyca.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…custom ID on preferences (#7094)

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Co-authored-by: Neville Samuell <NevilleS@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ation (#7345)

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Neville Samuell <NevilleS@users.noreply.github.com>
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…7384)

Co-authored-by: Jade Wibbels <jade@ethyca.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
tvandort and others added 13 commits February 25, 2026 14:40
Co-authored-by: Eliana Rosselli <67162025+erosselli@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…tion (#7467)

Co-authored-by: Cursor <cursoragent@cursor.com>
…nfig (#7472)

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: jpople <jeremy@ethyca.com>
…d→Approve

- Enable BrandFetch logo integration for infrastructure system list items
  (uncomment ENG-2391 code for vendor logo URL resolution and Avatar display)
- Show system descriptions as secondary text below system names
- Add monitor type tag (IDP/Web/Datastore) on MonitorResult in activity center
- Change "Add" terminology to "Approve" across all action cells and bulk menus

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Kelsey-Ethyca Kelsey-Ethyca requested a review from a team as a code owner February 25, 2026 22:17
@Kelsey-Ethyca Kelsey-Ethyca requested review from speaker-ender and removed request for a team February 25, 2026 22:17
@vercel
Copy link
Contributor

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Error Error Feb 26, 2026 6:08pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 26, 2026 6:08pm

Request Review

@Kelsey-Ethyca Kelsey-Ethyca added the do not merge Please don't merge yet, bad things will happen if you do label Feb 25, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 25, 2026

Greptile Summary

This PR enhances the Okta Monitor UX with four main improvements: vendor logos via BrandFetch, system descriptions, monitor type tags, and renaming "Add" to "Approve" throughout the UI.

Key Changes:

  • Enabled BrandFetch logo integration for infrastructure systems with proper fallback hierarchy (metadata URL → BrandFetch CDN → settings icon)
  • Added system descriptions as secondary text below system names for better context
  • Added monitor type tags (Web/Datastore/IDP) to activity center for quick identification
  • Consistently renamed all "Add" buttons and tooltips to "Approve" across individual actions, bulk actions, and error messages

Implementation Quality:

  • Proper use of useMemo for logo URL computation with correct dependencies
  • Safe conditional rendering for optional fields (item.description)
  • Type-safe constant mapping for monitor type labels using Record<MONITOR_TYPES, string>
  • Consistent accessibility updates with aria-labels matching button text

Confidence Score: 5/5

  • This PR is safe to merge with no blocking issues
  • The changes are straightforward UX improvements with proper type safety, safe rendering patterns, and consistent implementation across all affected files. The only minor style guide deviation (text-xs class) is an existing pattern used throughout the codebase.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResult.tsx Added monitor type tag labels (Web/Datastore/IDP) - clean implementation using proper constants
clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InfrastructureSystemListItem.tsx Enabled logo rendering with BrandFetch fallback and added description display - proper use of memoization and safe rendering

Last reviewed commit: cac8faa

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

)}
</Flex>
{item.description && (
<Text type="secondary" className="text-xs pl-1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text-xs tailwind class is used for font sizing. Per the frontend style guide, tailwind should only be used for layout and animation, not for typography sizing. Consider using Ant Design's Text component size prop or FidesUI palette/theme styling instead.

Context Used: Context from dashboard - Front-end developer rules (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

johnewart and others added 5 commits February 25, 2026 23:15
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: jpople <jeremy@ethyca.com>
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: jpople <jeremy@ethyca.com>
@Kelsey-Ethyca Kelsey-Ethyca marked this pull request as draft February 26, 2026 14:54
lucanovera and others added 2 commits February 26, 2026 15:05
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Please don't merge yet, bad things will happen if you do

Projects

None yet

Development

Successfully merging this pull request may close these issues.