Skip to content

feat: chromatic builds#7485

Merged
speaker-ender merged 2 commits intomainfrom
feat/chromatic-builds
Mar 2, 2026
Merged

feat: chromatic builds#7485
speaker-ender merged 2 commits intomainfrom
feat/chromatic-builds

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 25, 2026

Ticket []

Description Of Changes

Adding the initial CI integration that will publish fidesui storybook assets to chromatic.
Reduces chromatic builds by only running when changes are made to fidesui related code.

Code Changes

  • Adds a new github workflow file that runs chromatic builds

Steps to Confirm

  1. Confirm that chromatic builds in the pipeline here
  2. Log into chromatic using your github credentials
  3. Confirm that you are able to see the chromatic builds from this branch

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Mar 2, 2026 1:25pm
fides-privacy-center Ignored Ignored Mar 2, 2026 1:25pm

Request Review

@speaker-ender speaker-ender changed the title feat/chromatic-builds feat: chromatic builds Feb 25, 2026
@speaker-ender speaker-ender force-pushed the feat/chromatic-builds branch 6 times, most recently from dce071b to e0d310e Compare March 2, 2026 13:16
fix: missing job

fix: adding job name

fis: more step issues

fix: trying older node version to fix install

chore: test change detection

chore: update changelog

feat: more change detection

fix: missing logic check
@speaker-ender speaker-ender force-pushed the feat/chromatic-builds branch from e0d310e to fb27e6f Compare March 2, 2026 13:16
@speaker-ender speaker-ender marked this pull request as ready for review March 2, 2026 13:16
@speaker-ender speaker-ender requested a review from a team as a code owner March 2, 2026 13:16
@speaker-ender speaker-ender requested review from gilluminate and removed request for a team March 2, 2026 13:16
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 2, 2026

Greptile Summary

This PR adds initial Chromatic CI integration for publishing fidesui storybook assets. The workflow includes path filtering to only run chromatic builds when fidesui related code changes, which is an effective optimization.

Key Changes

  • New GitHub Actions workflow that checks for fidesUI changes before running Chromatic
  • Adds chromatic package as a dev dependency with appropriate npm script
  • Properly configured with TurboSnap (onlyChanged: true) for efficient snapshot testing

Issues Found

  • Inconsistent actions/checkout versions (v4 vs v5) within the same workflow file
  • Chromatic action uses unpinned @latest tag which could cause unexpected CI failures

Confidence Score: 4/5

  • Safe to merge after fixing version inconsistencies
  • The PR introduces a straightforward CI workflow addition with proper path filtering and configuration. The issues found are minor version inconsistencies that should be corrected but don't prevent functionality
  • .github/workflows/chromatic.yml needs version consistency fixes before merge

Important Files Changed

Filename Overview
.github/workflows/chromatic.yml adds chromatic CI workflow with path filtering; has version inconsistencies with checkout action and uses unpinned @latest for chromatic action
changelog/7485.yaml properly formatted changelog entry
clients/fidesui/package.json adds chromatic package and script with proper --exit-zero-on-changes flag
clients/package-lock.json automatic dependency lock file updates for chromatic package

Last reviewed commit: fb27e6f

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 421e843 Mar 2, 2026
43 of 45 checks passed
@speaker-ender speaker-ender deleted the feat/chromatic-builds branch March 2, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants