fix(p2p): skip addressbook and reacher for unreachable addresses#5370
Open
gacevicljubisa wants to merge 1 commit intomasterfrom
Open
fix(p2p): skip addressbook and reacher for unreachable addresses#5370gacevicljubisa wants to merge 1 commit intomasterfrom
gacevicljubisa wants to merge 1 commit intomasterfrom
Conversation
gacevicljubisa
changed the title
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos and
martinconic
janos
approved these changes
Feb 17, 2026
Member
janos
left a comment
janos
left a comment
There was a problem hiding this comment.
It would be good to have a test to ensure that the behaviour is kept, as the logic is adjusted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
When the peerstore has no addresses for a peer, peerMultiaddrs was falling back to RemoteMultiaddr (NAT IP + ephemeral port). This caused the reacher to ping unreachable ports and hive to gossip unreachable addresses.
Remove the fallback from peerMultiaddrs and handle it explicitly at call sites — RemoteMultiaddr is now only used as ObservedUnderlay for the handshake. Addressbook storage and reacher notifications are skipped when no real peerstore addresses are available.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):