fix: allow CSS-wide keywords in font-family-fallbacks#391
Open
sethamus wants to merge 2 commits intoeslint:mainfrom
Open
fix: allow CSS-wide keywords in font-family-fallbacks#391sethamus wants to merge 2 commits intoeslint:mainfrom
sethamus wants to merge 2 commits intoeslint:mainfrom
Conversation
3 tasks
Contributor
Tanujkanti4441
left a comment
Tanujkanti4441
left a comment
There was a problem hiding this comment.
Thanks for the PR, looks good, just a suggestion regarding docs.
Tanujkanti4441
added
the
accepted
DMartens
reviewed
Mar 5, 2026
| "fangsong", | ||
| ]); | ||
|
|
||
| const cssWideKeywords = new Set([ |
There was a problem hiding this comment.
Should we use sourceCode.lexer.cssWideKeywordsSyntax.map instead of this set?
This would allow users to fork the syntax and add css-wide keyword.
Contributor
Author
There was a problem hiding this comment.
What’s the motivating use case for extending cssWideKeywords?
Member
There was a problem hiding this comment.
I think this is a good idea for maintenance purposes. It gives us one less spot to update should things change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR fixes false positives in
css/font-family-fallbacksby allowing CSS-wide keywords (e.g.inherit,initial,unset,revert,revert-layer) forfont-family/font, since they shouldn’t be required to include fallback/generic fonts.What changes did you make? (Give an overview)
var()values).font-familyand shorthandfontCSS-wide keyword cases.Related Issues
Fixes #387
Is there anything you'd like reviewers to focus on?