Potential fix for code scanning alert no. 6: Clear-text logging of sensitive information#30
Merged
Potential fix for code scanning alert no. 6: Clear-text logging of sensitive information#30
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/erseco/python-moodle/security/code-scanning/6
To fix the issue, we should ensure that no log entry ever includes the password (or other secrets), and ideally avoid logging any structure derived directly from tainted data. Instead of copying and redacting the full payload, we can log only non-sensitive fields and static information, such as the URL and username, which are not secrets. That way, the debug log still provides useful context while guaranteeing that the password is not even indirectly part of the logged object.
Concretely, in
src/py_moodle/auth.pyinside_standard_login, we will replace the current debug block that createsredacted_payloadand logspayload={redacted_payload}with a simpler message that mentions only the login URL and the username. This removes any dependency on thepasswordfield and should satisfy CodeQL for all alert variants tied to this location. The tests intests/conftest.pydo not perform any logging of the password—they only pass it tologin—so they do not need code changes for this specific “clear-text logging” issue.No new imports or helper methods are needed; we will only adjust the existing
if self.debug:block around line 122 insrc/py_moodle/auth.py.Suggested fixes powered by Copilot Autofix. Review carefully before merging.