Skip to content

Feature/query store wait stats v1.1#153

Merged
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom
rferraton:feature/query-store-wait-stats-v1.1
Mar 28, 2026
Merged

Feature/query store wait stats v1.1#153
erikdarlingdata merged 2 commits intoerikdarlingdata:devfrom
rferraton:feature/query-store-wait-stats-v1.1

Conversation

@rferraton
Copy link
Copy Markdown
Contributor

What does this PR do?

  • Modify WaitStatsProfileControl to default to ribbon chart mode
  • Remove the grid data button from WaitStatsProfileControl header
  • Add legend button to WaitStatsProfileControl that opens a color legend popup
  • Add vertical dashed lines for day boundaries in WaitStatsRibbonControl
  • Align X-axis ticks/labels to day boundaries (00:00) in WaitStatsRibbonControl
  • Add horizontal dashed average line with label in WaitStatsRibbonControl
  • Apply FormatWaitRatio in WaitStatsRibbonControl tooltips
  • Apply FormatWaitRatio in WaitProfileBarControl tooltips
  • Apply FormatWaitRatio in WaitStatsProfileControl grid table rows
image

Why this PR

  • Waits stats by hours is more interesting than global waits stats so i switch to this view by default
  • Adding day boundaries help to see when things happened
  • Adding the avg waittime ratio will help to see how much the wait are importants without needed to use tooltips
  • I switch the wait ratio units to something more human readable
    • ms/sec under 1
    • sec/sec between 1 and 60
    • min/sec above 60

Which component(s) does this affect?

  • Desktop App (PlanViewer.App)
  • Core Library (PlanViewer.Core)
  • CLI Tool (PlanViewer.Cli)
  • SSMS Extension (PlanViewer.Ssms)
  • Tests
  • Documentation

How was this tested?

2026-03-28_18h46_43

Describe the testing you've done. Include:

  • Plan files tested : Query Store
  • Platforms tested : Windows Only

Checklist

  • I have read the contributing guide
  • My code builds with zero warnings (dotnet build -c Debug)
  • All tests pass (dotnet test)
  • I have not introduced any hardcoded credentials or server names

- Modify WaitStatsProfileControl to default to ribbon chart mode
- Remove the grid data button from WaitStatsProfileControl header
- Add legend button to WaitStatsProfileControl that opens a color legend popup
- Add vertical dashed lines for day boundaries in WaitStatsRibbonControl
- Align X-axis ticks/labels to day boundaries (00:00) in WaitStatsRibbonControl
- Add horizontal dashed average line with label in WaitStatsRibbonControl
- Apply FormatWaitRatio in WaitStatsRibbonControl tooltips
- Apply FormatWaitRatio in WaitProfileBarControl tooltips
- Apply FormatWaitRatio in WaitStatsProfileControl grid table rows
…er light grey background

- switch wait color legend to the right of the global wait header
@erikdarlingdata erikdarlingdata merged commit fbd47b0 into erikdarlingdata:dev Mar 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants