Integrate installation into Dashboard Add Server dialog (#755 Phase 2)#763
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 30, 2026
Merged
Integrate installation into Dashboard Add Server dialog (#755 Phase 2)#763erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
…Phase 2) Add Server dialog now detects the PerformanceMonitor database state after Test Connection and offers Install Now / Upgrade options inline. New features: - Database status detection: no DB → Install Now, old version → Upgrade, current version → "up to date" - Full installation with progress bar, scrolling log, and cancel button - Advanced options (collapsed): clean install, reset schedule, validation, community dependencies - Credential separation: post-install prompt for lower-privilege monitoring credentials (SQL auth only) - Installation report generation with View Report button - "Skip, just add server" link to bypass installation - Edit mode skips all installation detection (existing behavior preserved) Technical: - Dashboard references Installer.Core, uses ScriptProvider.FromEmbeddedResources() (SQL scripts embedded in assembly — no filesystem dependency) - State machine (DialogState enum) drives panel visibility - All UI updates wrapped in Dispatcher.Invoke for thread safety - Connection test targets master (not PerformanceMonitor) so it succeeds when the database doesn't exist yet - Save button uses MinWidth+Padding to fit "Save & Connect" text Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ScriptProvider.FromEmbeddedResources()— SQL scripts embedded in Installer.Core assemblyPhase 2 of #755. Phase 3 (retire InstallerGui) will follow.
Test plan
🤖 Generated with Claude Code