Fix Lite memory leaks: delta cache, event handlers, chart helpers (#758)#760
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 30, 2026
Merged
Fix Lite memory leaks: delta cache, event handlers, chart helpers (#758)#760erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
…758) - DeltaCalculator: add ClearServer() to free cache when server tab closes - MainWindow: store event handler delegates so they can be unsubscribed on tab close (AlertCountsChanged, ApplyTimeRangeRequested, ManualRefreshRequested) - ChartHoverHelper: add Dispose() to unsubscribe MouseMove/MouseLeave events - ServerTab: add DisposeChartHelpers() to clean up all 27 hover helpers - CloseServerTab now calls all cleanup methods Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClearServer()to evict all cached entries when a server tab is closed. Previously the cache grew unbounded for the lifetime of the process.AlertCountsChanged,ApplyTimeRangeRequested,ManualRefreshRequested) were subscribed but never unsubscribed on close. Now stored as named delegates and unsubscribed inCloseServerTab.Dispose()to unsubscribeMouseMove/MouseLeavefrom chart controls. 27 instances per tab were keeping the entire visual tree alive via event references.DisposeChartHelpers()called fromCloseServerTab.Addresses #758 - high memory consumption (5+ GB) when running Lite over extended periods.
Test plan
🤖 Generated with Claude Code