Exclude vtk 9.5 until segfaults have been addressed#1351
Open
drocheam wants to merge 3 commits intoenthought:mainfrom
Open
Exclude vtk 9.5 until segfaults have been addressed#1351drocheam wants to merge 3 commits intoenthought:mainfrom
drocheam wants to merge 3 commits intoenthought:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing mayavi with vtk 9.5 leads to issues, see #1346 and #1350
Restricting
"vtk < 9.5"in the requirements resolves them.It seems version specific segfaults must be addressed by excluding some vtk classes, as it was always done in https://github.com/enthought/mayavi/blob/main/tvtk/vtk_module.py
In my opinion, vtk versions should always be restricted up to the newest, tested version.
New vtk releases often led to installation issues in the past.
This is especially frustrating, as there are only infrequent updates to the mayavi PyPI version (sometimes over a year apart).