Avoid eagerly importing nock outside of testing#923
Merged
SergeAstapov merged 3 commits intoembermap:masterfrom Dec 3, 2025
Merged
Avoid eagerly importing nock outside of testing#923SergeAstapov merged 3 commits intoembermap:masterfrom
SergeAstapov merged 3 commits intoembermap:masterfrom
Conversation
This was referenced Dec 3, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
nockis imported eagerly in the local ember app builds. As nock is activated in import (see https://github.com/nock/nock/blob/v15.0.0/index.js#L49), this can create an issue when nock v15 is used with native fetch, which leads to fastboot rendering failing on local due to failing API calls