Stop checking for - in component file names#752
Open
chriskrycho wants to merge 1 commit intoember-cli:masterfrom
Open
Stop checking for - in component file names#752chriskrycho wants to merge 1 commit intoember-cli:masterfrom
- in component file names#752chriskrycho wants to merge 1 commit intoember-cli:masterfrom
Conversation
This restriction was lifted a long time ago, and is particularly out of step with Glimmer component usage.
Contributor
|
Looks like some tests need removing as well. |
Author
|
Yep. Figured that'd be the case – did the first change from the GitHub UI. 😂 Will finish this off later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restriction was lifted a long time ago, and is particularly out of step with Glimmer component usage.