irq-ts71xxweim: add IRQ ack and ack_mask functions#275
Open
anakin-childerhose-sfl wants to merge 4 commits intoembeddedTS:linux-6.6.yfrom
Open
irq-ts71xxweim: add IRQ ack and ack_mask functions#275anakin-childerhose-sfl wants to merge 4 commits intoembeddedTS:linux-6.6.yfrom
anakin-childerhose-sfl wants to merge 4 commits intoembeddedTS:linux-6.6.yfrom
Conversation
Support both rev56 and rev65 of FPGA firmware by checking TSWEIM_IRQ_ACK_MODE_EN in TSWEIM_IRQ_ACK_MODE.
priv->mask by default will be initialized with 0. This may not accurately reflect the value in TSWEIM_IRQ_MASK. Initialize priv->mask with TSWEIM_IRQ_MASK to ensure the variable is synced with the register.
Since tsweim_intc_probe() uses platform_set_drvdata(), tsweim_intc_remove() should use platform_get_drvdata() instead of dev_get_platdata().
| { | ||
| struct tsweim_intc *priv = irq_data_get_irq_chip_data(d); | ||
|
|
||
| if (priv->revision >= 65) { |
There was a problem hiding this comment.
- if (priv->revision >= 65) {
+ if (priv->revision >= 65 && priv->ack_mode_en) {|
|
||
| raw_spin_unlock(&priv->lock); | ||
|
|
||
| if (priv->revision >= 65) { |
There was a problem hiding this comment.
- if (priv->revision >= 65) {
+ if (priv->revision >= 65 && priv->ack_mode_en) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
These commits have been tested on a ts7250 v3 with FPGA firmware rev65 by jumping the RX and TX pins together for the three RS-232 UARTS and running them all at 115200 baud for a period of time:
The output of linux-serial-test for each tty: