Bug fix: for credentials cope with trailing slash signing key calculation.#20
Open
morkevicius wants to merge 1 commit intoemartech:masterfrom
Open
Bug fix: for credentials cope with trailing slash signing key calculation.#20morkevicius wants to merge 1 commit intoemartech:masterfrom
morkevicius wants to merge 1 commit intoemartech:masterfrom
Conversation
presumably bug fix, this makes it calculate the signing key the same way as js version does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
presumably bug fix, this makes it calculate the signing key the same way as js version does, given that credential_scope ends with the trailing slash like 'my/credentials/scope/', js version splits it into ['my', 'credentials', 'scope', ''], ruby without this splits it into ['my', 'credentials', 'scope'], all test passes, so in other words test case for this particular case wasn't ever there.