You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@jalcine Thank you for this pr, but I'm sorry I don't think it's time to merge it now.
I have a branch here to refactor the whole project, I plan to make coverage check and docs(#85) in this pr.
But I don't have enough time on it, so I still need some time to finish it.
Ah, okay, that's cool! This doesn't impact master heavily so I think keeping it open until that refactor is done is cool (unless you think closing it is best).
Do you have tasks/features/goals for this refactor? This project is pretty important to me - I'd like to help out.
modularize codebase (about 85% finished)
with this feature, people can easy to add custom DSL, such as
custom_dsl do
end
get do
xxxx
end
context variable (this is a break change)
for now, there're two internal variables conn and params. I want to add another one context what people can get maru router related information from.
also I don't like hidden variables, maybe use new DSL for endpoints like (haven't decided)
get :path, fn conn, params, context ->
xxxx
end
get :path, &AnotherModule.endpoint_func/3
use config from custom application and custom the supervisor tree
for now we have to use config :maru, MY_MODULE to config maru, will add new way like
defmodule MyAPI do
use Maru.Router, Application.get_env(:my_app, :my_api)
end
and provide MyAPI.child_spec function to help use to make maru application under any supervisor tree.
Code Style
complete @specdocs and unit test, move all docs to hexdocs Upload Docs to hexdocs #85
also format code with elixir 1.6 formatter.
@jalcine I'm really glad to hear what you think about maru, Thank you very much!
Let's keep this pr open, and merge it after the first task modularize codebase merged.
Sorry, I closed this prematurely. Did you merge that modularize codebase branch? IF so, I can begin working to add more tests and make sure coverage is up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to help out more with this project but I feel that in order to properly
do so without adding code bloat, coverage checking would be helpful.