fix: revert canvas-builder from Dockerfile, restore publish-hostless pipeline#140
Open
jameswillis99 wants to merge 2 commits intomasterfrom
Open
fix: revert canvas-builder from Dockerfile, restore publish-hostless pipeline#140jameswillis99 wants to merge 2 commits intomasterfrom
jameswillis99 wants to merge 2 commits intomasterfrom
Conversation
…es yarn install The canvas-packages prepare script runs makePkgTypes.js during yarn install. Both makePkgTypes.js and typedPkgsList.json must be present before yarn install runs, otherwise the postinstall step fails with MODULE_NOT_FOUND. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…pipeline Remove the canvas-builder stage from the WAB Dockerfile and restore the Dockerfile.publish-hostless approach. The publish-hostless workflow now builds canvas-packages in CI, layers them on top of the deployed WAB image via Dockerfile.publish-hostless, and runs the ECS task. Network config now comes from GitHub environment variables (PRIVATE_SUBNET_IDS, ECS_SECURITY_GROUP_ID) rather than terraform outputs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makePkgTypes.jsbuild failures)Dockerfile.publish-hostlesswhich layers canvas-packages on top of the deployed WAB imagePRIVATE_SUBNET_IDS,ECS_SECURITY_GROUP_ID)Test plan
deploy-integrationworkflow builds and pushes WAB image successfullypublish-hostlessworkflow and verify it builds canvas-packages, builds the publish-hostless image, and runs the ECS task to completionPRIVATE_SUBNET_IDSandECS_SECURITY_GROUP_IDare set in theintegrationGitHub environment🤖 Generated with Claude Code