Conversation
The SKU field was not being properly returned when using Item.all() due to the field not being explicitly requested in the query. This commit: 1. Adds test_sku_in_all() to tests/integration/test_item.py to verify SKU field retrieval 2. Removes trailing slashes from API URLs in get_single_object method 3. Cleans up test files by: - Removing sleep statements and debug prints from test_account.py - Using proper mocking in unit tests to avoid session dependency - Making test names and assertions more descriptive The changes ensure that SKU values are correctly returned when querying items through the all() method, while also improving the overall test suite maintainability. Testing: - Added new integration test verifying SKU field retrieval - All existing Item and Account tests pass - Unit tests properly mock session dependencies
build and publish wheel
add Cost Rate (Fixes #372)
Add SKU to Item
attachable bytes
use minorversion 75 by default
Fix incompatibility issue with setuptools >= 78
Fix setuptools dashes into underscore
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #386 +/- ##
==========================================
- Coverage 93.53% 93.26% -0.28%
==========================================
Files 104 104
Lines 3991 4009 +18
Branches 108 118 +10
==========================================
+ Hits 3733 3739 +6
- Misses 219 224 +5
- Partials 39 46 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.