feat: extra registration fields improvements#9
Open
BryanttV wants to merge 10 commits intoednx-release/teak.masterfrom
Open
feat: extra registration fields improvements#9BryanttV wants to merge 10 commits intoednx-release/teak.masterfrom
BryanttV wants to merge 10 commits intoednx-release/teak.masterfrom
Conversation
|
This is a very nice improvement to the user experience, but if we don't contribute it back upstream, we'd have to maintain it ourselves. Can we consider opening this against upstream master? |
Author
|
@mariajgrimaldi, Yes, I definitely think that would be the best option. I didn't choose to push it directly to upstream right away because the unit tests aren't ready yet, and I'd also like to have it reviewed from a front-end perspective before publishing it to upstream. |
315e000 to
610a0a6
Compare
…and option handling
9cf0660 to
cc0f791
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/eduNEXT/consulting-issues-mapping/issues/829
Description
This PR improves the
FormFieldRenderercomponent and the configurable registration form with better UX feedback, input validation, and more robust error message handling.textandtextareafields inFormFieldRenderer.maxLengthrestriction applied natively on text inputs usingfieldData.restrictions.max_length.fieldData.instructionswhile the field is focused, usingTransitionReplace.normalizeErrorMessageutility that converts backend error messages arriving as objects (e.g.,{ required: "..." }) to strings, preventing[object Object]from being displayed.Testing Instructions
Using Tutor:
tutor mounts add frontend-app-authnnvm use && npm installDate of birth.Screenshots/sandbox (optional):