Skip to content

Day2 recipe maker#2816

Closed
26harvintilavat wants to merge 3 commits intoed-donner:mainfrom
26harvintilavat:day2-recipe-maker
Closed

Day2 recipe maker#2816
26harvintilavat wants to merge 3 commits intoed-donner:mainfrom
26harvintilavat:day2-recipe-maker

Conversation

@26harvintilavat
Copy link
Copy Markdown
Contributor

Day 2 Assignment – Recipe Maker using Ollama

Overview

This PR adds a Recipe Maker notebook that generates structured recipes using a local Ollama LLM.

Features

  • Uses strong system prompt for chef-style reasoning
  • Generates complete recipes with ingredients, steps, tips, and nutrition estimate
  • Supports beginner-friendly cooking instructions
  • Works fully offline using Ollama

Goal

To practice prompt engineering and local LLM integration as part of Day-2 assignment.

Notes

  • Added only my assignment file inside Harvin/ folder
  • No existing project files were modified intentionally

@ed-donner
Copy link
Copy Markdown
Owner

Hey,
I'm super grateful that you've worked on this and are sharing your contribution. It looks like this might not be ready to be merged - please can I ask you to review this:

https://edwarddonner.com/pr

The most common issue is that you've included a file outside community-contributions. This would impact all students on the course. You can see this by going to the "Files changed" tab in this PR; the only changes should be to files in community-contributions.

If there's a good reason to change files outside community-contributions, like an important bug fix, then please let me know (and thank you!)

The 2nd most common reason is that you've not cleared outputs of Notebooks, leading to large code changes. Instructions at the link above.

The 3rd common reason is that you've included too many changes, such as many thousands of lines of code, or a large number of files. I'm grateful for your work, but see the link above for ways we can include this without the repo getting too large.

The PR details in this Github screen shows you the files changed, and at the top right the number of lines added (in Green) and deleted (in Red) by this PR. Typically the Green number should be less than 2,000 and the red number should be 0.

I very much look forward to merging when this is addressed. Thanks so much
Ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants