[GEF] Use EditPartViewer interface when creating UI actions
#1366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 720 files 2 720 suites 12h 45m 13s ⏱️ Results for commit e303255. ♻️ This comment has been updated with latest results. |
The `IEditPartViewer` is a WindowBuilder-specific subclass of the GEF EditPartViewer. But none of its methods are required when creating these actions. By removing it now, we avoid type-cast errors when using those actions for pure GEF viewers.
ptziegler
force-pushed
the
edit-part-viewer-for-ui-actions
branch
from
73545fd to
e303255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
IEditPartVieweris a WindowBuilder-specific subclass of the GEF EditPartViewer. But none of its methods are required when creating these actions.By removing it now, we avoid type-cast errors when using those actions for pure GEF viewers.