Skip to content

[2043] Ensure user libraries stays under User library folder#2077

Merged
AxelRICHARD merged 1 commit intomainfrom
gco/fix/2043
Mar 19, 2026
Merged

[2043] Ensure user libraries stays under User library folder#2077
AxelRICHARD merged 1 commit intomainfrom
gco/fix/2043

Conversation

@gcoutable
Copy link
Member

@gcoutable gcoutable commented Mar 18, 2026 •
edited
Loading

Bug: #2043
Signed-off-by: Guillaume Coutable guillaume.coutable@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@gcoutable gcoutable added this to the 2026.3.0 milestone Mar 18, 2026
@gcoutable gcoutable linked an issue Mar 18, 2026 that may be closed by this pull request
Imported user libraries become non-library documents once modified #2043
Closed
AxelRICHARD
AxelRICHARD reviewed Mar 18, 2026
View reviewed changes
...ipse/syson/application/controllers/explorer/view/ExplorerViewControllerIntegrationTests.java Outdated
.verify(Duration.ofSeconds(10));
}

@DisplayName("GIVEN the SysON Explorer View, WHEN we direct edit an element of an imported read-only user library, THEN the user library is updated")
Copy link
Member

@AxelRICHARD AxelRICHARD Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you talking about direct edit here? and how a read-only library can be updated?

Copy link
Member Author

@gcoutable gcoutable Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the title

@gcoutable
[2043] Ensure user libraries stays under User library folder
1d83ade 
Bug: #2043
Signed-off-by: Guillaume Coutable <guillaume.coutable@obeo.fr>

# Conflicts:
#	CHANGELOG.adoc
@AxelRICHARD AxelRICHARD merged commit f54a422 into main Mar 19, 2026
4 checks passed
@AxelRICHARD AxelRICHARD deleted the gco/fix/2043 branch March 19, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD approved these changes

Assignees

No one assigned

Labels

pr: to review soon priority: high

Projects

None yet

Milestone

2026.3.0

Development

Successfully merging this pull request may close these issues.

Imported user libraries become non-library documents once modified

2 participants

@gcoutable @AxelRICHARD