Fix for data are not flushed to disk in context of Kvs::flush()#254
Open
tizava wants to merge 4 commits intoeclipse-score:mainfrom
Open
Fix for data are not flushed to disk in context of Kvs::flush()#254tizava wants to merge 4 commits intoeclipse-score:mainfrom
tizava wants to merge 4 commits intoeclipse-score:mainfrom
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
arkjedrz
requested changes
Mar 17, 2026
Contributor
arkjedrz
left a comment
arkjedrz
left a comment
There was a problem hiding this comment.
Overall LGTM, small issues observed.
| /* Helper: write data to a file and ensure it reaches physical storage.*/ | ||
| score::ResultBlank Kvs::write_and_sync(const std::string& path, const void* data, std::size_t size) | ||
| { | ||
| auto file_deleter = [](std::FILE* f) { |
Contributor
There was a problem hiding this comment.
Is this actually a deleter? This looks more like FILE cleanup.
Contributor
There was a problem hiding this comment.
From the point of view of a smart pointer (std::unique_ptr in this case) it is a deleter as it frees memory resources (through fclose) when the smart pointer ends its life when exiting the scope according to the RAII paradigm.
src/cpp/src/kvs.cpp
Outdated
| return score::MakeUnexpected(ErrorCode::PhysicalStorageFailure); | ||
| } | ||
|
|
||
| /* Flush the C library buffer to the OS. */ |
Contributor
There was a problem hiding this comment.
Is it a "flush of a C library buffer", or "flush buffer to the OS using C library"? Why mention C library at all?
Contributor
There was a problem hiding this comment.
I think it's better "flush the buffer to the OS" without mentioning the C library. I'll push a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: 252
In old implementation data were only written using std::fostream, which is an asynchronous API.
Flush to the physical storage is required as well to ensure all the data are persisted.
The std::ostream::flush() will only flush the C++ buffer to OS (Not to the disk), therefore fstream API has been replaced with cstdio.
Posix fdatasync() API, which is synchronous is now called to ensure all buffers are properly flushed.