Add missing descriptions to Colours and Fonts theme entries in Preferences #2453
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
via ThemeElementCategory, while others do not. This change uses the existing descriptions to display in the description box and adds description for ones that doesn't have any entries to ensure the description area is not left empty and that available descriptions are consistently utilised. This aligns with the standard usage elsewhere in Eclipse preference pages. The main change pertaining to this has been merged in eclipse.platform.ui via eclipse-platform/eclipse.platform.ui#3666 and the remaining part is addressed via this change.
Contributor
Member
Author
|
Build looks good, merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent use of descriptions in Colours and Fonts preferences
Some entries in the Colours and Fonts preference page already provide descriptions, while others leave the description area empty. This change makes use of the existing descriptions and applies them to theme entries so that the description box is consistently populated and available descriptions are properly utilised. This improves clarity and aligns the presentation with the approach used with the subtree elements in Eclipse preference pages and gives more clarity on what each entity is used for. The Colours and Fonts preference page shows a description panel which is empty now. There are already descriptions available for some and not available for rest and they are not being used so as to display in the box. This change adds the existing description usage to theme entries so that users always see meaningful information when navigating these settings.
The main change pertaining to this PR has been merged via eclipse-platform/eclipse.platform.ui#3666 and some of the remaining changes are addressed here.