Remove redundant GC.dispose() calls for Image objects #3692
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
reviewed
Jan 21, 2026
| gc.drawRectangle(offset, offset, usableImageSize - offset, usableImageSize - offset); | ||
| gc.fillRectangle(offset + 1, offset + 1, usableImageSize - offset - 1, | ||
| usableImageSize - offset - 1); | ||
| gc.dispose(); |
Contributor
There was a problem hiding this comment.
When will the image of this GC be disposed? It's not that obvious so it might be that this GC lives for a very long time. Couldn't the image creation be changed to an ImageGcDrawer instead?
Contributor
Author
There was a problem hiding this comment.
replaced with ImageGcDrawer
Contributor
Author
There was a problem hiding this comment.
Moved it to seperate PR as the commit message does not fit with the change to ImageGcDrawer
arunjose696
force-pushed
the
arunjose696/RemoveGCDispose
branch
2 times, most recently
from
d27685a to
a40ab81
Compare
This minor refactoring eliminates unnecessary calls to GC.dispose() since disposing an Image automatically disposes its associated GC. There is no visual impact from this change.
arunjose696
force-pushed
the
arunjose696/RemoveGCDispose
branch
from
a40ab81 to
3f40c99
Compare
akoch-yatta
approved these changes
Jan 22, 2026
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
LGTM, image is disposed right after
The second place was converted to a ImageGcDrawer and into a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minor refactoring removes unnecessary calls to GC.dispose(), as disposing an Image automatically disposes its associated GC.
The images affected by this change are the color-rectangle visuals used in the color selector and syntax coloring. I tested the behavior both before and after the change and observed no visual differences.