Skip to content

feat: use Cargo.toml as version source, add tests and structured logging#6

Merged
AlexanderKlump merged 7 commits intomainfrom
add-tests-and-debug-output
Feb 25, 2026
Merged

feat: use Cargo.toml as version source, add tests and structured logging#6
AlexanderKlump merged 7 commits intomainfrom
add-tests-and-debug-output

Conversation

@AlexanderKlump
Copy link
Copy Markdown
Contributor

@AlexanderKlump AlexanderKlump commented Feb 18, 2026 •
edited
Loading

https://easybill.atlassian.net/browse/PLAT-291

Changes:

  • added tests
    • unit tests
      • mtc and force_success checks: using tmp files
      • tcp connection checks: using a connector trait, which can be mocked with deterministic streams
      • http checks: using a connector trait, which can be mocked with deterministic duplex streams
    • integration tests: by running the binary
      • mtc and force success
      • http server
      • tcp endpoint
  • added CI test run
  • uses Cargo.toml as source for version number
  • added debug logging output

Disclaimer:

  • these changes were created by using Claude Code
  • I reviewed all lines of code by myself with an explanation of Claude Code

hasenbanck
hasenbanck reviewed Feb 19, 2026
View reviewed changes
Comment thread src/checks/http_response_check.rs Outdated
@AlexanderKlump AlexanderKlump force-pushed the add-tests-and-debug-output branch 2 times, most recently from 767d4c9 to 37af55d Compare February 20, 2026 18:59
@AlexanderKlump AlexanderKlump force-pushed the add-tests-and-debug-output branch from 37af55d to 7f18138 Compare February 20, 2026 19:02
@AlexanderKlump AlexanderKlump force-pushed the add-tests-and-debug-output branch from 0ba5296 to e8924cb Compare February 23, 2026 10:51
@AlexanderKlump AlexanderKlump marked this pull request as ready for review February 23, 2026 11:00
hasenbanck
hasenbanck requested changes Feb 25, 2026
View reviewed changes
Comment thread src/util/tcp_connector.rs
Comment thread tests/integration.rs Outdated
Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
Comment thread Cargo.toml Outdated
Comment thread src/checks/http_response_check.rs Outdated
hasenbanck
hasenbanck reviewed Feb 25, 2026
View reviewed changes
Comment thread Cargo.toml Outdated
@AlexanderKlump AlexanderKlump merged commit b4916da into main Feb 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hasenbanck hasenbanck hasenbanck approved these changes

@regexident regexident Awaiting requested review from regexident

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexanderKlump @hasenbanck