Skip to content

[24067] RPC refactor#6308

Merged
rsanchez15 merged 22 commits intomasterfrom
fast/rpc-refactor
Feb 24, 2026
Merged

[24067] RPC refactor#6308
rsanchez15 merged 22 commits intomasterfrom
fast/rpc-refactor

Conversation

@emiliocuestaf
Copy link
Copy Markdown
Contributor

@emiliocuestaf emiliocuestaf commented Feb 10, 2026

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO: Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@emiliocuestaf emiliocuestaf changed the title Fast/rpc refactor [24067] Fast/rpc refactor Feb 10, 2026
@github-actions github-actions Bot added the ci-pending PR which CI is running label Feb 12, 2026
@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima February 12, 2026 08:57
@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima February 12, 2026 09:01
@emiliocuestaf emiliocuestaf added this to the v3.5.0 milestone Feb 12, 2026
Comment thread include/fastdds/rtps/builtin/data/SubscriptionBuiltinTopicData.hpp Outdated
@eProsima eProsima deleted a comment from cferreiragonz Feb 13, 2026
@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima February 13, 2026 10:21
@emiliocuestaf emiliocuestaf added the needs-review PR that is ready to be reviewed label Feb 13, 2026
@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima February 13, 2026 10:23
@emiliocuestaf emiliocuestaf changed the title [24067] Fast/rpc refactor [24067] RPC refactor Feb 13, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 13, 2026

🧪 CI Insights

Here's what we observed from your CI run for e3624c9.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
Fast DDS MacOS CI mac-ci / fastdds_test () Unknown 0 View View
Fast DDS Windows CI windows-ci / fastdds_test (RelWithDebInfo, examples), v142 Unknown 0 View View

@emiliocuestaf emiliocuestaf requested review from richiprosima and removed request for richiprosima February 16, 2026 10:59
Comment thread include/fastdds/dds/domain/DomainParticipant.hpp Outdated
Comment thread include/fastdds/dds/domain/DomainParticipant.hpp Outdated
Comment thread include/fastdds/dds/rpc/exceptions.hpp Outdated
Comment thread include/fastdds/dds/rpc/interfaces.hpp Outdated
Comment thread src/cpp/fastdds/rpc/RequestReplyContentFilter.hpp Outdated
Comment thread test/blackbox/common/DDSBlackboxTestsBasic.cpp
Comment thread test/unittest/rtps/builtin/BuiltinDataSerializationTests.cpp
Comment thread test/unittest/dds/participant/ParticipantTests.cpp Outdated
Comment thread test/unittest/dds/participant/ParticipantTests.cpp
Comment thread test/unittest/dds/participant/ParticipantTests.cpp
Comment thread test/unittest/dds/participant/ParticipantTests.cpp Outdated
Comment thread src/cpp/fastdds/domain/DomainParticipantImpl.hpp Outdated
Comment thread src/cpp/fastdds/domain/DomainParticipantImpl.hpp Outdated
@MiguelCompany MiguelCompany removed the request for review from richiprosima February 18, 2026 09:56
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
…rticipant.h

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
@emiliocuestaf emiliocuestaf marked this pull request as ready for review February 24, 2026 11:03
@emiliocuestaf emiliocuestaf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Feb 24, 2026
@rsanchez15 rsanchez15 merged commit e516400 into master Feb 24, 2026
42 of 47 checks passed
@rsanchez15 rsanchez15 deleted the fast/rpc-refactor branch February 24, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants