Skip to content

Push firecracker to all environments on release#20

Merged
dobrac merged 6 commits intomainfrom
push-firecracker-on-release
May 6, 2026
Merged

Push firecracker to all environments on release#20
dobrac merged 6 commits intomainfrom
push-firecracker-on-release

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented Apr 18, 2026

No description provided.

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 18, 2026

PR Summary

Medium Risk
Changes the release pipeline control flow and deploy behavior across multiple environments; mistakes could skip needed builds or publish/deploy incomplete artifacts.

Overview
The workflow now always runs build, publish, and deploy, relying on per-arch checks and has_new_artifacts gating instead of a global skip_build, which can still trigger deploy even when nothing new was produced.

Several GitHub Actions references look invalid (actions/checkout@v6, actions/upload-artifact@v7, actions/download-artifact@v8) and will likely break the workflow.

scripts/validate.py drops --github-repo and changes artifact detection to read release assets via gh release view, and tests are rewritten accordingly; this can mis-detect assets if the gh repo context isn’t what you expect.

Reviewed by Cursor Bugbot for commit 61d32f0. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 553b1f8. Configure here.

Comment thread .github/workflows/release.yml
Comment thread scripts/validate.py
@cla-bot cla-bot Bot added the cla-signed label May 6, 2026
@dobrac dobrac merged commit a433d41 into main May 6, 2026
7 checks passed
@dobrac dobrac deleted the push-firecracker-on-release branch May 6, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants