Skip to content

fix(types): replace @returns any with specific type for withDefaults in utils.js#2364

Open
jonathanKingston wants to merge 11 commits intomainfrom
claude/fix-any-type-patch-07-sqf19
Open

fix(types): replace @returns any with specific type for withDefaults in utils.js#2364
jonathanKingston wants to merge 11 commits intomainfrom
claude/fix-any-type-patch-07-sqf19

Conversation

@jonathanKingston
Copy link
Copy Markdown
Contributor

@jonathanKingston jonathanKingston commented Feb 28, 2026

Asana Task/Github Issue:

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

The withDefaults function already casts all return paths to D & C
(intersection of the defaults and config template types). Update the
JSDoc @returns annotation to match, replacing the loose any.

https://claude.ai/code/session_01QaZ2NFE7y5u8YdZhjoc79m


Note

Low Risk
Type-only change that updates withDefaults JSDoc to return D & C instead of any, with no runtime behavior modifications.

Overview
Updates withDefaults in injected/src/utils.js to annotate its JSDoc return type as D & C (intersection of defaults and config) instead of any, aligning docs/types with the existing casts and improving TypeScript inference without changing runtime behavior.

Written by Cursor Bugbot for commit c9bf50c. This will update automatically on new commits. Configure here.

…in utils.js

The withDefaults function already casts all return paths to D & C
(intersection of the defaults and config template types). Update the
JSDoc @returns annotation to match, replacing the loose any.

https://claude.ai/code/session_01QaZ2NFE7y5u8YdZhjoc79m
daxtheduck
daxtheduck previously approved these changes Feb 28, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 28, 2026

[Beta] Generated file diff

Time updated: Wed, 04 Mar 2026 14:11:24 GMT

@daxtheduck daxtheduck dismissed their stale review February 28, 2026 09:56

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Feb 28, 2026
@daxtheduck daxtheduck dismissed their stale review February 28, 2026 11:31

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Feb 28, 2026
@daxtheduck daxtheduck dismissed their stale review March 1, 2026 22:57

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Mar 1, 2026
@daxtheduck daxtheduck dismissed their stale review March 2, 2026 00:09

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Mar 2, 2026
@daxtheduck daxtheduck dismissed their stale review March 2, 2026 12:16

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Mar 2, 2026
@daxtheduck daxtheduck dismissed their stale review March 3, 2026 10:21

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Mar 3, 2026
@daxtheduck daxtheduck dismissed their stale review March 3, 2026 11:51

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Mar 3, 2026
@daxtheduck daxtheduck dismissed their stale review March 3, 2026 12:18

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Mar 3, 2026
@daxtheduck daxtheduck dismissed their stale review March 3, 2026 15:06

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

daxtheduck
daxtheduck previously approved these changes Mar 3, 2026
@daxtheduck daxtheduck dismissed their stale review March 4, 2026 14:10

Dismissing stale approval — new commits pushed, awaiting Cursor re-review.

@github-actions github-actions Bot added the patch Increment the patch version when merged label Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants