Skip to content

Failing pixel report#7864

Merged
nalcalag merged 2 commits intodevelopfrom
feature/noelia/fix_browser_menu_pixel_definition
Mar 6, 2026
Merged

Failing pixel report#7864
nalcalag merged 2 commits intodevelopfrom
feature/noelia/fix_browser_menu_pixel_definition

Conversation

@nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Mar 4, 2026

Task/Issue URL: https://app.asana.com/1/137249556945/task/1213478675582883?focus=true

Description

Added missing params to pixel definition

Steps to test this PR

  • N/A

No UI changes


Note

Low Risk
Low risk: changes are limited to pixel metadata and query-param stripping for a single pixel, with no user-facing behavior changes.

Overview
Fixes browser menu pixel definitions by adding missing appVersion/atb parameters to m_nav_pm_o and adding appVersion to m_nav_vpn_menu_item_pressed.

Updates PixelParamRemovalInterceptor to also strip atb from AppPixelName.MENU_ACTION_VPN_PRESSED, keeping emitted parameters consistent with expectations.

Written by Cursor Bugbot for commit 1eda628. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

nalcalag commented Mar 4, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review March 4, 2026 15:38
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Privacy Review task: https://app.asana.com/0/69071770703008/1213554496189803

Copy link
Collaborator

@ladamski ladamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience here @nalcalag !

@nalcalag nalcalag merged commit 2654030 into develop Mar 6, 2026
15 checks passed
@nalcalag nalcalag deleted the feature/noelia/fix_browser_menu_pixel_definition branch March 6, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants