Lint cleanup: fix TypographyEllipsis issues across 6 modules#7852
Closed
Lint cleanup: fix TypographyEllipsis issues across 6 modules#7852
Conversation
joshliebe
approved these changes
Mar 3, 2026
Contributor
joshliebe
left a comment
joshliebe
left a comment
There was a problem hiding this comment.
LGTM, just need to check that maestro tests pass and I would suggest syncing the changes with smartling.
Replace 180 occurrences of three-dot "..." with the unicode ellipsis character (…) across translated string resources in 6 modules: sync-impl, autofill-impl, subscriptions-impl, network-protection-impl, vpn-impl, and saved-sites-impl. Regenerated lint baselines accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
malmstein
force-pushed
the
feature/lint-cleanup-phase1-typography-ellipsis
branch
from
5c8b0e5 to
f674985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1157893581871903/task/1213509412926464
Description
Replace 180 occurrences of three-dot
...with the unicode ellipsis character…(U+2026) in translated string resources across 6 modules: sync-impl (44), autofill-impl (31), subscriptions-impl (29), network-protection-impl (25), vpn-impl (15), and saved-sites-impl (6). Lint baselines regenerated for all affected modules.This is Phase 1 of the lint baseline cleanup effort (parent task: https://app.asana.com/1/137249556945/project/1157893581871903/task/1207933312028021).
Steps to test this PR
Lint verification
./gradlew :sync-impl:lintDebugpasses./gradlew :autofill-impl:lintDebugpasses./gradlew :subscriptions-impl:lintDebugpasses./gradlew :network-protection-impl:lintDebugpasses./gradlew :vpn-impl:lintDebugpasses./gradlew :saved-sites-impl:lintDebugpassesTypographyEllipsisissues remain in any of the 6 module baselinesUI changes
No UI changes — the unicode ellipsis character renders identically to three dots.
Note
Low Risk
Low risk: string-only localization tweaks (replacing
...with…) and lint baseline regeneration; no logic or behavior changes expected beyond text rendering.Overview
Cleans up Android lint
TypographyEllipsiswarnings by replacing three-dot...sequences with the Unicode ellipsis…in multiple localized string resources (notably invpn-impl,autofill-impl, andnetwork-protection-impl).Regenerates the affected
lint-baseline.xmlfiles to remove the now-resolvedTypographyEllipsisentries.Written by Cursor Bugbot for commit 5c8b0e5. This will update automatically on new commits. Configure here.